Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ungoogled-chromium: 84.0.4147.89-1 -> 85.0.4183.102-1 #98231

Merged
merged 1 commit into from Sep 19, 2020

Conversation

@squalus
Copy link
Contributor

@squalus squalus commented Sep 18, 2020

Motivation for this change

This updates ungoogled-chromium. This change was created by manually copying the regular chromium expressions and applying a small diff to support the ungoogled patchset.

Performed a cursory test and everything looks good.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @danielfullmer

based on chromium master@05f5001c
@danielfullmer
Copy link
Contributor

@danielfullmer danielfullmer commented Sep 18, 2020

Built and briefly tested working on twitch/youtube/etc.

@squalus
Copy link
Contributor Author

@squalus squalus commented Sep 19, 2020

@primeos primeos merged commit 54a0a40 into NixOS:master Sep 19, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
ungoogled-chromium, ungoogled-chromium.passthru.tests on aarch64-linux No attempt
Details
ungoogled-chromium, ungoogled-chromium.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8344cba"; rev="8344cbaf17d643bd4eed9cf39f9c412d3a19364d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8344cba"; rev="8344cbaf17d643bd4eed9cf39f9c412d3a19364d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8344cba"; rev="8344cbaf17d643bd4eed9cf39f9c412d3a19364d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8344cba"; rev="8344cbaf17d643bd4eed9cf39f9c412d3a19364d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8344cba"; rev="8344cbaf17d643bd4eed9cf39f9c412d3a19364d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8344cba"; rev="8344cbaf17d643bd4eed9cf39f9c412d3a19364d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8344cba"; rev="8344cbaf17d643bd4eed9cf39f9c412d3a19364d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@primeos
Copy link
Member

@primeos primeos commented Sep 19, 2020

Thanks :)
Cherry-picked to 20.09 in bfb429d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.