Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcv-rack: fix broken pffft reference #98237

Closed
wants to merge 2 commits into from
Closed

Conversation

@lb5tr
Copy link
Contributor

@lb5tr lb5tr commented Sep 18, 2020

vcv-rack: fix broken pffft reference
(cherry picked from commit 5096b51)

Reason: only changed download ref. Source code of pffft remains unchanged.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
flokli and others added 2 commits Sep 12, 2020
Useful when you want to point datadog to another endpoint, either
because you need a proxy to send out data, or because you use their EU
endpoint.

(cherry picked from commit 2865a88)
vcv-rack: fix broken pffft reference
(cherry picked from commit 5096b51)

Reason: only changed download ref. Source code of pffft remains unchanged.
@lb5tr lb5tr mentioned this pull request Sep 18, 2020
4 of 10 tasks complete
@zimbatm zimbatm force-pushed the NixOS:nixos-20.09 branch from be92e21 to 3b8ddb2 Sep 24, 2020
@ajs124
Copy link
Member

@ajs124 ajs124 commented Sep 28, 2020

There's a few things wrong with this:

  1. it needs to go into release-20.09, not nixos-20.09
  2. it includes the wrong commits, 2865a88/be92e21 is completely unrelated and 5096b51/f2a5a20 is the merge instead of the actual change.

See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes for more details on how to backport changes.

@lb5tr
Copy link
Contributor Author

@lb5tr lb5tr commented Sep 28, 2020

OK, i'll submit a fresh PR

@lb5tr lb5tr closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.