Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] topydo: Don't fail build on tests #98241

Merged
merged 1 commit into from Sep 22, 2020

Conversation

@Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Sep 18, 2020

Motivation for this change

(cherry picked from commit 9d30512)

backport of #98110

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@risicle
Copy link
Contributor

@risicle risicle commented Sep 19, 2020

Again, we need the backport information on the actual commit message

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 20, 2020

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@Pamplemousse Pamplemousse force-pushed the Pamplemousse:backport_topydo branch from 9d30512 to 8fceca7 Sep 22, 2020
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
(cherry picked from commit c603f62)
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:backport_topydo branch from 8fceca7 to 0fc6cda Sep 22, 2020
@Pamplemousse Pamplemousse requested review from jonringer and risicle Sep 22, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98241 1

1 package built:
  • topydo

@jonringer jonringer merged commit 8e0373f into NixOS:release-20.09 Sep 22, 2020
18 checks passed
18 checks passed
action
Details
topydo, topydo.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fc6cda"; rev="0fc6cda298e9c57571a9f0e74c5aa6ac3ec68b00"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fc6cda"; rev="0fc6cda298e9c57571a9f0e74c5aa6ac3ec68b00"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fc6cda"; rev="0fc6cda298e9c57571a9f0e74c5aa6ac3ec68b00"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fc6cda"; rev="0fc6cda298e9c57571a9f0e74c5aa6ac3ec68b00"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fc6cda"; rev="0fc6cda298e9c57571a9f0e74c5aa6ac3ec68b00"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fc6cda"; rev="0fc6cda298e9c57571a9f0e74c5aa6ac3ec68b00"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fc6cda"; rev="0fc6cda298e9c57571a9f0e74c5aa6ac3ec68b00"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
topydo, topydo.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.