Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/activation: fix type for activationScripts and userActivationScripts #98257

Closed
wants to merge 1 commit into from

Conversation

@ryantm
Copy link
Member

@ryantm ryantm commented Sep 19, 2020

The problem: activationScripts (in my use case, deps) cannot be
overriden because merging of types.unspecified depends on the module
evaluation order.

types.unspecified.merge [] [ { value = { text = "a"; dep = "b"; }; } { value = { dep = "c"; }; } ]
{ dep = "c"; text = "a"; }

The fix: give it a good type that handles merging in the typical way!

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
…ripts

The problem: activationScripts (in my use case, deps) cannot be
overriden because merging of types.unspecified depends on the module
evaluation order.

> types.unspecified.merge [] [ { value = { text = "a"; dep = "b"; }; } { value = { dep = "c"; }; } ]
{ dep = "c"; text = "a"; }

The fix: give it a good type that handles merging in the typical way!
@ryantm
Copy link
Member Author

@ryantm ryantm commented Nov 13, 2020

superseded by #101755

@ryantm ryantm closed this Nov 13, 2020
@ryantm ryantm deleted the ryantm:activationscript branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.