Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas: enable multiple outputs #98337

Merged
merged 1 commit into from Oct 5, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 20, 2020

Motivation for this change

noticed cmake and pkgconfig files were being propagated when reviewing #98335

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

modest closure decrease:

$ nix path-info -Sh ./result
/nix/store/9ygjz2yfbfizgs4i7qrz1ync14mfh7bf-openblas-0.3.10	  68.0M
# with changes
$ nix path-info -Sh ./result
/nix/store/v8slfaawv5bg40zf44ab9aqi54sr88p6-openblas-0.3.10	  66.6M
@jonringer jonringer changed the base branch from master to staging Sep 20, 2020
@jonringer jonringer force-pushed the openblas-multiple-outputs branch from 1b45ef6 to 598b04a Sep 20, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Sep 20, 2020

sorry for spam, had to rebase onto staging, 2600 packages were changed

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Sep 21, 2020

still "reviewing"

[64/5453/8228 built (98 failed), 2 copied (0.1/0.1 MiB), 0.1 MiB DL]

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 5, 2020

I didn't see any initial failures out of this, we can look at regressions on staging-next

@jonringer jonringer merged commit 7902256 into NixOS:staging Oct 5, 2020
21 of 22 checks passed
markuskowa added a commit to markuskowa/nixpkgs that referenced this issue Oct 19, 2020
Fall out from switching openblas over to multiple outputs:
NixOS#98337
markuskowa added a commit to markuskowa/NixOS-QChem that referenced this issue Oct 19, 2020
Fall out from switching openblas over to multiple outputs:
NixOS/nixpkgs#98337
markuskowa added a commit to markuskowa/NixOS-QChem that referenced this issue Oct 19, 2020
Fall out from switching openblas over to multiple outputs:
NixOS/nixpkgs#98337
sdier added a commit to sdier/nixpkgs that referenced this issue Oct 23, 2020
Fall out from switching openblas over to multiple outputs:
NixOS#98337
Preisschild added a commit to Preisschild/nixpkgs that referenced this issue Oct 27, 2020
Fall out from switching openblas over to multiple outputs:
NixOS#98337
Preisschild added a commit to Preisschild/nixpkgs that referenced this issue Oct 27, 2020
Fall out from switching openblas over to multiple outputs:
NixOS#98337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants