Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustscan: 1.8.0 -> 1.10.1 #98410

Merged
merged 3 commits into from Oct 19, 2020
Merged

rustscan: 1.8.0 -> 1.10.1 #98410

merged 3 commits into from Oct 19, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Sep 21, 2020

Motivation for this change

Keep things up to date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@NieDzejkob
Copy link
Contributor

@NieDzejkob NieDzejkob commented Sep 21, 2020

Fails to build on NixOS. This seems to be because one of the tests got split. I am currently testing this change:

-    "--skip=parse_correct_ips_or_hosts"
+    "--skip=parse_correct_host_addresses"

@NieDzejkob
Copy link
Contributor

@NieDzejkob NieDzejkob commented Sep 21, 2020

With the above changes, the package builds and runs fine on NixOS.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Sep 21, 2020

Changed.

I built it locally and nothing failed. Are the tests more strict on nixOS compared to nix? And why is graham green if the tests fail in nixOS? I am a bit confused right now. Can you maybe clear this up or reference some documentation about this?

@NieDzejkob
Copy link
Contributor

@NieDzejkob NieDzejkob commented Sep 22, 2020

Perhaps the sandbox is off by default on foreign distributions? Also, I had the impression that the CI hooked up to GitHub PRs only checks whether the derivations instantiate without errors...

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Sep 22, 2020

Sandbox is disabled on Debian and Ubuntu because it sometimes causes really strange errors when building certain packages. Not ideal for package maintenance but I try to keep it in mind and maybe change that in the future.

@SuperSandro2000 SuperSandro2000 changed the title rustscan: 1.8.0 -> 1.9.0 rustscan: 1.8.0 -> 1.10.0 Sep 29, 2020
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Sep 29, 2020

@NieDzejkob Could you maybe take another look if it still builds/passes tests on nixOS? (I should setup some VM...)

@NieDzejkob
Copy link
Contributor

@NieDzejkob NieDzejkob commented Sep 29, 2020

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Sep 29, 2020

you could also try enabling the sandbox in your configuration file on your machine. That should catch most issues ;)

Then some nodePackages are not building.

@NieDzejkob
Copy link
Contributor

@NieDzejkob NieDzejkob commented Sep 30, 2020

parse_correct_host_addresses still fails in 1.10.1 when sandboxed due to the network being unavailable. Your latest commit shouldn't be removing that skip flag.

@SuperSandro2000 SuperSandro2000 force-pushed the rustscan-1.9.0 branch 2 times, most recently from 9ba36c8 to ef52d44 Sep 30, 2020
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 1, 2020

I finally set up a Vagrant box to properly test with sandbox. 🎉

@SuperSandro2000 SuperSandro2000 changed the title rustscan: 1.8.0 -> 1.10.0 rustscan: 1.8.0 -> 1.10.1 Oct 14, 2020
@Mic92 Mic92 merged commit 2ee6d46 into NixOS:master Oct 19, 2020
19 checks passed
@SuperSandro2000 SuperSandro2000 deleted the rustscan-1.9.0 branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants