Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordnet: Fix darwin build #98415

Merged
merged 1 commit into from Oct 18, 2020
Merged

wordnet: Fix darwin build #98415

merged 1 commit into from Oct 18, 2020

Conversation

@anka-213
Copy link
Contributor

@anka-213 anka-213 commented Sep 21, 2020

Motivation for this change

Building on darwin was failing with error:

14 warnings generated.
clang  -g -O2   -o wishwn  wishwn-tkAppInit.o wishwn-stubs.o -L../lib -lWN -L/nix/store/vmpwxmns16dhv0d1nhyaxjxwjwzazp52-tk-8.6.9/lib -ltk
ld: framework not found Cocoa
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

This patch adds the missing dependency on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@anka-213 anka-213 force-pushed the anka-213:fix-wordnet branch from 4f8e9e2 to a1b319d Sep 21, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Sep 26, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/308

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 27, 2020

@GrahamcOfBorg build wordnet

@anka-213
Copy link
Contributor Author

@anka-213 anka-213 commented Oct 1, 2020

Btw, should I add myself as a maintainer, since there is none currently?

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 1, 2020

Yes, I think so.

Borg doesn't have a darwin builder anymore and that doesn't seem like it will be fixed soon.

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 1, 2020

Btw, should I add myself as a maintainer, since there is none currently?

If you care about this package yes, please go on and add yourself. There are lots of orphaned packages in Nixpkgs that needs some love.

ofBorg didn't manage to built this on darwin yet, must be stuck or very overloaded. I'll take your word it builds because I have no other means to test this.

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 1, 2020

Borg doesn't have a darwin builder anymore and that doesn't seem like it will be fixed soon.

Ah, I didn't know that. That's sad.

EDIT:

Here's the reason: NixOS/ofborg#529 (comment)

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 8, 2020

So, should I go on and merge or are you adding yourself to the maintainers list?

vcunat added a commit that referenced this pull request Oct 18, 2020
(cherry picked from commit 81b1356)
@vcunat vcunat merged commit 81b1356 into NixOS:master Oct 18, 2020
21 of 22 checks passed
21 of 22 checks passed
tests tests
Details
action
Details
wordnet on x86_64-darwin
Details
wordnet on aarch64-linux No attempt
Details
wordnet, wordnet.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a6df8a"; rev="0a6df8a06627cab6e6c558d98eb89494e48c29a5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a6df8a"; rev="0a6df8a06627cab6e6c558d98eb89494e48c29a5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a6df8a"; rev="0a6df8a06627cab6e6c558d98eb89494e48c29a5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a6df8a"; rev="0a6df8a06627cab6e6c558d98eb89494e48c29a5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a6df8a"; rev="0a6df8a06627cab6e6c558d98eb89494e48c29a5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a6df8a"; rev="0a6df8a06627cab6e6c558d98eb89494e48c29a5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a6df8a"; rev="0a6df8a06627cab6e6c558d98eb89494e48c29a5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
wordnet on x86_64-linux Success
Details
wordnet, wordnet.passthru.tests on x86_64-linux Success
Details
@vcunat
Copy link
Member

@vcunat vcunat commented Oct 18, 2020

Well, meta.maintainers can be extended anytime later; let's not keep this rotting.

vcunat added a commit that referenced this pull request Oct 20, 2020
(cherry picked from commit 81b1356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.