Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.gym: fix dependency constraints #98591

Merged
merged 1 commit into from Oct 6, 2020
Merged

Conversation

@wkral
Copy link
Contributor

@wkral wkral commented Sep 23, 2020

Motivation for this change

Found cloudpickle dependency has been expanded in openai/gym#2032 and tests are passing without any changes.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wkral wkral requested review from FRidh and jonringer as code owners Sep 23, 2020
@wkral
Copy link
Contributor Author

@wkral wkral commented Sep 23, 2020

Result of nixpkgs-review pr 98591 1

1 package failed to build:
  • python37Packages.rl-coach
5 packages built:
  • python37Packages.baselines
  • python37Packages.gym
  • python37Packages.roboschool
  • python38Packages.gym
  • python38Packages.roboschool

@wkral wkral requested a review from jonringer Oct 2, 2020
@wkral
Copy link
Contributor Author

@wkral wkral commented Oct 4, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 4, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 4, 2020
@wkral
Copy link
Contributor Author

@wkral wkral commented Oct 4, 2020

/status needs_reviewer

timokau
timokau approved these changes Oct 6, 2020
Copy link
Member

@timokau timokau left a comment

Thanks!

'';
# cloudpickle range has been expanded in package but not yet released
Copy link
Member

@timokau timokau Oct 6, 2020

For future PRs, I think it would be better to have the comment before the thing you're commenting on. At least that seems to be the standard. Not important enough to hold this up though.

@timokau timokau merged commit e76833e into NixOS:master Oct 6, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants