Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neovim-qt from 0.2.15 to 0.2.16.1 #98605

Merged

Conversation

@unclechu
Copy link
Contributor

@unclechu unclechu commented Sep 24, 2020

Motivation for this change

It didn’t update for quite a while (since 2019).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
    Set via config argument in this command: nix-shell --pure -E 'let p=import ./. {config.useSandbox=true;}; in p.mkShell {buildInputs=[p.neovim-qt];}' --run nvim-qt
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@unclechu
Copy link
Contributor Author

@unclechu unclechu commented Sep 24, 2020

Currently it fails to compile with this end of the log (trying with nix-shell --pure -E 'let p=import ./. {config.useSandbox=true;}; in p.mkShell {buildInputs=[p.neovim-qt];}' --run nvim-qt):

make  -f test/CMakeFiles/check.dir/build.make test/CMakeFiles/check.dir/build
make[3]: Entering directory '/build/source/build'
cd /build/source/build/test && /nix/store/70y1dj79fq7f6486y8clrgngrcfr303q-cmake-3.18.2/bin/ctest
Test project /build/source/build/test
      Start  1: tst_neovimobject
      Start  2: tst_neovimconnector
      Start  3: tst_callallmethods
      Start  4: tst_encoding
      Start  5: tst_msgpackiodevice
      Start  6: tst_input_mac
      Start  7: tst_input_unix
      Start  8: tst_input_win32
 1/11 Test  #2: tst_neovimconnector ..............Child aborted***Exception:   0.10 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


      Start  9: tst_input_common_mac
 2/11 Test  #4: tst_encoding .....................Child aborted***Exception:   0.11 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


      Start 10: tst_input_common_unix
 3/11 Test  #1: tst_neovimobject .................Child aborted***Exception:   0.12 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


      Start 11: tst_input_common_win32
 4/11 Test  #7: tst_input_unix ...................Child aborted***Exception:   0.12 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


 5/11 Test  #3: tst_callallmethods ...............Child aborted***Exception:   0.12 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


 6/11 Test  #6: tst_input_mac ....................Child aborted***Exception:   0.13 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


 7/11 Test  #8: tst_input_win32 ..................Child aborted***Exception:   0.13 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


 8/11 Test  #5: tst_msgpackiodevice ..............Child aborted***Exception:   0.15 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


 9/11 Test  #9: tst_input_common_mac .............Child aborted***Exception:   0.08 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


10/11 Test #10: tst_input_common_unix ............Child aborted***Exception:   0.08 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.


11/11 Test #11: tst_input_common_win32 ...........Child aborted***Exception:   0.08 sec
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.



0% tests passed, 11 tests failed out of 11

Total Test time (real) =   0.20 sec

The following tests FAILED:
          1 - tst_neovimobject (Child aborted)
          2 - tst_neovimconnector (Child aborted)
          3 - tst_callallmethods (Child aborted)
          4 - tst_encoding (Child aborted)
          5 - tst_msgpackiodevice (Child aborted)
          6 - tst_input_mac (Child aborted)
          7 - tst_input_unix (Child aborted)
          8 - tst_input_win32 (Child aborted)
          9 - tst_input_common_mac (Child aborted)
         10 - tst_input_common_unix (Child aborted)
         11 - tst_input_common_win32 (Child aborted)
Errors while running CTest
make[3]: *** [test/CMakeFiles/check.dir/build.make:76: test/CMakeFiles/check] Error 8
make[3]: Leaving directory '/build/source/build'
make[2]: *** [CMakeFiles/Makefile2:978: test/CMakeFiles/check.dir/all] Error 2
make[2]: Leaving directory '/build/source/build'
make[1]: *** [CMakeFiles/Makefile2:985: test/CMakeFiles/check.dir/rule] Error 2
make[1]: Leaving directory '/build/source/build'
make: *** [Makefile:554: check] Error 2
builder for '/nix/store/npncywa24r4da94xljqmncw9wqknrrkr-neovim-qt-unwrapped-0.2.16.1.drv' failed with exit code 2
cannot build derivation '/nix/store/5vpxbg06vnrsm5kjvbz7jmvg9p5jck5w-neovim-qt-0.2.16.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5vpxbg06vnrsm5kjvbz7jmvg9p5jck5w-neovim-qt-0.2.16.1.drv' failed
@unclechu
Copy link
Contributor Author

@unclechu unclechu commented Sep 24, 2020

Turned off cmake tests, not sure if it is the right thing to do but it fixes the build. And I can run the app with this command:

nix-shell --pure -E 'let p=import ./. {config.useSandbox=true;}; in p.mkShell {buildInputs=[p.neovim-qt];}' --run nvim-qt

And this newer version actually fixes one of the issues I just reported today:
equalsraf/neovim-qt#755

@unclechu unclechu changed the title WIP: Update neovim-qt from 0.2.15 to 0.2.16.1 Update neovim-qt from 0.2.15 to 0.2.16.1 Sep 24, 2020
@ofborg ofborg bot requested a review from peterhoeg Sep 24, 2020
@unclechu
Copy link
Contributor Author

@unclechu unclechu commented Sep 24, 2020

In case someone doesn’t have time to wait here how I overridden it for myself:
unclechu/nixos-config@4f3bf55

@gebner gebner force-pushed the unclechu:patch/unclechu/update-neovim-qt-to-0.2.16.1 branch from 7d27711 to 897d92c Oct 3, 2020
@gebner gebner merged commit bf77b6d into NixOS:master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
neovim-qt, neovim-qt.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897d92c"; rev="897d92c8546f6d01fbfc74e573a26f134c392cc6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897d92c"; rev="897d92c8546f6d01fbfc74e573a26f134c392cc6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897d92c"; rev="897d92c8546f6d01fbfc74e573a26f134c392cc6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897d92c"; rev="897d92c8546f6d01fbfc74e573a26f134c392cc6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897d92c"; rev="897d92c8546f6d01fbfc74e573a26f134c392cc6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897d92c"; rev="897d92c8546f6d01fbfc74e573a26f134c392cc6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="897d92c"; rev="897d92c8546f6d01fbfc74e573a26f134c392cc6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
neovim-qt, neovim-qt.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.