Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all non-mainline U-Boots #98607

Merged
merged 1 commit into from Oct 7, 2020

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Sep 24, 2020

Motivation for this change

Keeping untested, and untestable packages around is not great.

As maintainer of U-Boot-related things, I want to remove the last non-mainline U-Boot from Nixpkgs.

All mainline-based U-Boots are basically free, assuming that mainline keeps them in working order.

From this point forward, it would be ideal to not add non-mainline U-Boot to Nixpkgs. Let's see if we can do it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @viric who introduced and maintained the package.

This removes the last non-mainline U-Boot from Nixpkgs.
@samueldr
Copy link
Member Author

@samueldr samueldr commented Oct 7, 2020

Given it's been almost two full weeks, I don't think there is any objection.

@samueldr samueldr merged commit 433db45 into NixOS:master Oct 7, 2020
16 checks passed
16 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d2d18c"; rev="3d2d18cdb8a3c77ee27bd7f548da33e8b2e5f40e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d2d18c"; rev="3d2d18cdb8a3c77ee27bd7f548da33e8b2e5f40e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d2d18c"; rev="3d2d18cdb8a3c77ee27bd7f548da33e8b2e5f40e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d2d18c"; rev="3d2d18cdb8a3c77ee27bd7f548da33e8b2e5f40e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d2d18c"; rev="3d2d18cdb8a3c77ee27bd7f548da33e8b2e5f40e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d2d18c"; rev="3d2d18cdb8a3c77ee27bd7f548da33e8b2e5f40e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3d2d18c"; rev="3d2d18cdb8a3c77ee27bd7f548da33e8b2e5f40e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@samueldr samueldr deleted the samueldr:u-boot/remove-downstream-u-boots branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.