Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wtf: 0.31.0 -> 0.32.0 #98622

Merged
merged 1 commit into from Oct 7, 2020
Merged

wtf: 0.31.0 -> 0.32.0 #98622

merged 1 commit into from Oct 7, 2020

Conversation

@avdv
Copy link
Contributor

@avdv avdv commented Sep 24, 2020

Semi-automatic update generated by nixpkgs-update tools.

meta.description for wtf is: "The personal information dashboard for your terminal"

meta.homepage for wtf is: "https://wtfutil.com/"

meta.changelog for wtf is: ""

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 0.32.0 with grep in /nix/store/33ky4cyrz4qwzwcax2zmz9zz118gl3ll-wtf-0.32.0


Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

0 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
wtf
Instructions to test this update (click to expand)

Build yourself:

nix-build -A wtf https://github.com/avdv/nixpkgs/archive/946d8304bc9b0a3153fd60247a54a6f56aa0fc0b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/33ky4cyrz4qwzwcax2zmz9zz118gl3ll-wtf-0.32.0
ls -la /nix/store/33ky4cyrz4qwzwcax2zmz9zz118gl3ll-wtf-0.32.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
  • wtf

Maintainer pings

cc @kalbasit @kalbasit for testing.

Copy link
Member

@stigtsp stigtsp left a comment

Build OK on x64 linux, but build FAILS on x64 darwin:

go: downloading github.com/huandu/xstrings v1.2.0
go: downloading github.com/fatih/color v1.7.0
go: downloading github.com/mndrix/tap-go v0.0.0-20170113192335-56cca451570b
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d
installing
hash mismatch in fixed-output derivation '/nix/store/cbn96y1r2h21a9zrsrr1ffgm25nlbcgg-wtf-0.32.0-go-modules':
  wanted: sha256:0l1q29mdb13ir7n1x65jfnrmy1lamlsa6hm2jagf6yjbm6wf1kw4
  got:    sha256:0p4cy7snxkx5in7c0nsy6bm0f1gn297rzwalm5rdfvhgdlb102nw
cannot build derivation '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv' failed
@avdv
Copy link
Contributor Author

@avdv avdv commented Sep 24, 2020

Build OK on x64 linux, but build FAILS on x64 darwin:

Do you know why this happens? Is package resolution platform dependent in Go?

@avdv
Copy link
Contributor Author

@avdv avdv commented Sep 28, 2020

Build OK on x64 linux, but build FAILS on x64 darwin:

go: downloading github.com/huandu/xstrings v1.2.0
go: downloading github.com/fatih/color v1.7.0
go: downloading github.com/mndrix/tap-go v0.0.0-20170113192335-56cca451570b
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d
installing
hash mismatch in fixed-output derivation '/nix/store/cbn96y1r2h21a9zrsrr1ffgm25nlbcgg-wtf-0.32.0-go-modules':
  wanted: sha256:0l1q29mdb13ir7n1x65jfnrmy1lamlsa6hm2jagf6yjbm6wf1kw4
  got:    sha256:0p4cy7snxkx5in7c0nsy6bm0f1gn297rzwalm5rdfvhgdlb102nw
cannot build derivation '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv' failed

I have no idea whether this is the right thing to do (it feels wrong...), but I changed the vendor SHA based on the platform.

@avdv avdv requested a review from stigtsp Sep 28, 2020
@stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 28, 2020

I have no idea whether this is the right thing to do (it feels wrong...), but I changed the vendor SHA based on the platform.

I'm not that experienced with Go, so unsure myself. But I share your feeling that it seems wrong.

@avdv
Copy link
Contributor Author

@avdv avdv commented Sep 28, 2020

Here's the list of go modules which are downloaded when building the go-modules derivation on x64 (from https://logs.nix.ci/?attempt_id=e585fe01-1c04-49e1-aa92-1f99613dedb6&key=nixos%2Fnixpkgs.98622):

go: downloading github.com/olebedev/config v0.0.0-20190528211619-364964f3a8e4
go: downloading github.com/briandowns/openweathermap v0.0.0-20180804155945-5f41b7c9d92d
go: downloading github.com/google/go-github/v26 v26.1.3
go: downloading github.com/mmcdole/gofeed v1.0.0
go: downloading github.com/rivo/tview v0.0.0-20200108161608-1316ea7a4b35
go: downloading github.com/radovskyb/watcher v1.0.7
go: downloading github.com/ovh/cds v0.0.0-20200131143542-5e69464c6598
go: downloading github.com/docker/docker v1.13.1
go: downloading github.com/digitalocean/godo v1.42.1
go: downloading github.com/microsoft/azure-devops-go-api/azuredevops v0.0.0-20191014190507-26902c1d4325
go: downloading github.com/gdamore/tcell v1.3.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/google/go-querystring v1.0.0
go: downloading google.golang.org/api v0.30.0
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/zmb3/spotify v0.0.0-20191010212056-e12fb981aacb
go: downloading github.com/PagerDuty/go-pagerduty v0.0.0-20191002190746-f60f4fc45222
go: downloading github.com/adlio/trello v1.7.0
go: downloading github.com/shirou/gopsutil v2.20.7+incompatible
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/mmcdole/goxpp v0.0.0-20181012175147-0068e33feabf
go: downloading github.com/alecthomas/chroma v0.8.0
go: downloading github.com/gdamore/encoding v1.0.0
go: downloading golang.org/x/sys v0.0.0-20200803210538-64077c9b5642
go: downloading github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e
go: downloading golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9
go: downloading github.com/rivo/uniseg v0.1.0
go: downloading github.com/andygrunwald/go-gerrit v0.0.0-20190825170856-5959a9bf9ff8
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/lucasb-eyer/go-colorful v1.0.2
go: downloading github.com/pkg/profile v1.5.0
go: downloading github.com/dustin/go-humanize v1.0.0
go: downloading google.golang.org/appengine v1.6.6
go: downloading github.com/hekmon/transmissionrpc v0.0.0-20190525133028-1d589625bacd
go: downloading github.com/PuerkitoBio/goquery v1.5.0
go: downloading github.com/docker/go-connections v0.4.0
go: downloading cloud.google.com/go v0.62.0
go: downloading github.com/jessevdk/go-flags v1.4.0
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/wtfutil/spotigopher v0.0.0-20191127141047-7d8168fe103a
go: downloading k8s.io/client-go v10.0.0+incompatible
go: downloading github.com/logrusorgru/aurora v0.0.0-20190803045625-94edacc10f9b
go: downloading github.com/nicklaw5/helix v0.5.9
go: downloading golang.org/x/net v0.0.0-20200707034311-ab3426394381
go: downloading code.cloudfoundry.org/bytefmt v0.0.0-20190819182555-854d396b647c
go: downloading github.com/golang/protobuf v1.4.2
go: downloading k8s.io/apimachinery v0.0.0-20190223094358-dcb391cde5ca
go: downloading google.golang.org/protobuf v1.25.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/StackExchange/wmi v0.0.0-20190523213315-cbe66965904d
go: downloading golang.org/x/text v0.3.3
go: downloading github.com/dlclark/regexp2 v1.2.0
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/andybalholm/cascadia v1.0.0
go: downloading k8s.io/api v0.0.0-20181204000039-89a74a8d264d
go: downloading github.com/danwakefield/fnmatch v0.0.0-20160403171240-cbb64ac3d964
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/godbus/dbus v4.1.0+incompatible
go: downloading github.com/google/gofuzz v1.0.0
go: downloading github.com/gophercloud/gophercloud v0.5.0
go: downloading github.com/zorkian/go-datadog-api v2.29.0+incompatible
go: downloading github.com/gogo/protobuf v1.2.1
go: downloading k8s.io/klog v0.2.0
go: downloading github.com/hekmon/cunits v2.0.1+incompatible
go: downloading github.com/VictorAvelar/devto-api-go v1.0.0
go: downloading github.com/wtfutil/todoist v0.0.2-0.20191216004217-0ec29ceda61a
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/stretchr/testify v1.6.1
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/googleapis/gnostic v0.1.0
go: downloading github.com/go-ole/go-ole v1.2.4
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/imdario/mergo v0.3.8
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/gregjones/httpcache v0.0.0-20190212212710-3befbb6ad0cc
go: downloading github.com/xanzy/go-gitlab v0.33.0
go: downloading gotest.tools v2.2.0+incompatible
go: downloading gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c
go: downloading github.com/peterbourgon/diskv v2.0.1+incompatible
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/google/go-cmp v0.5.1
go: downloading github.com/Azure/go-autorest v11.1.2+incompatible
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/google/btree v1.0.0
go: downloading github.com/json-iterator/go v1.1.7
go: downloading go.opencensus.io v0.22.4
go: downloading github.com/hashicorp/go-retryablehttp v0.6.4
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/dgrijalva/jwt-go v3.2.0+incompatible
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/Microsoft/go-winio v0.4.14
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading golang.org/x/time v0.0.0-20191024005414-555d28b269f0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading google.golang.org/genproto v0.0.0-20200804131852-c06518451d9c
go: downloading github.com/ovh/venom v0.25.0
go: downloading github.com/sguiheux/go-coverage v0.0.0-20190710153556-287b082a7197
go: downloading github.com/sirupsen/logrus v1.4.2
go: downloading github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b
go: downloading github.com/fatih/color v1.7.0
go: downloading github.com/fsamin/go-dump v1.0.9
go: downloading gopkg.in/AlecAivazis/survey.v1 v1.7.1
go: downloading github.com/spf13/cobra v0.0.5
go: downloading github.com/go-gorp/gorp v2.0.0+incompatible
go: downloading github.com/pborman/uuid v1.2.0
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/mitchellh/hashstructure v0.0.0-20170609045927-2bca23e0e452
go: downloading github.com/maruel/panicparse v1.3.0
go: downloading github.com/ovh/cds/sdk/interpolate v0.0.0-20190319104452-71125b036b25
go: downloading github.com/konsorten/go-windows-terminal-sequences v1.0.2
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/eapache/go-resiliency v1.1.0
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/mitchellh/mapstructure v1.1.2
go: downloading github.com/inconshreveable/mousetrap v1.0.0
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/huandu/xstrings v1.2.0
go: downloading github.com/aokoli/goutils v1.1.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d
go: downloading github.com/mndrix/tap-go v0.0.0-20170113192335-56cca451570b

@stigok Do you have the list for Darwin at hand? Are there any differences?

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 28, 2020

@aanderse can you trigger a darwin build for this PR?

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 28, 2020

The order of the output is different, but content is the same when sorted.

Build output from Darwin (the previous commit):

go: downloading github.com/alecthomas/chroma v0.8.0
go: downloading github.com/docker/docker v1.13.1
go: downloading github.com/gdamore/tcell v1.3.0
go: downloading github.com/xanzy/go-gitlab v0.33.0
go: downloading k8s.io/client-go v10.0.0+incompatible
go: downloading github.com/google/go-github/v26 v26.1.3
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/rivo/tview v0.0.0-20200108161608-1316ea7a4b35
go: downloading github.com/pkg/profile v1.5.0
go: downloading github.com/radovskyb/watcher v1.0.7
go: downloading github.com/ovh/cds v0.0.0-20200131143542-5e69464c6598
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading k8s.io/apimachinery v0.0.0-20190223094358-dcb391cde5ca
go: downloading golang.org/x/text v0.3.3
go: downloading golang.org/x/sys v0.0.0-20200803210538-64077c9b5642
go: downloading github.com/olebedev/config v0.0.0-20190528211619-364964f3a8e4
go: downloading github.com/hashicorp/go-retryablehttp v0.6.4
go: downloading github.com/VictorAvelar/devto-api-go v1.0.0
go: downloading github.com/gdamore/encoding v1.0.0
go: downloading k8s.io/klog v0.2.0
go: downloading github.com/gogo/protobuf v1.2.1
go: downloading github.com/imdario/mergo v0.3.8
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/andygrunwald/go-gerrit v0.0.0-20190825170856-5959a9bf9ff8
go: downloading github.com/dustin/go-humanize v1.0.0
go: downloading golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9
go: downloading github.com/logrusorgru/aurora v0.0.0-20190803045625-94edacc10f9b
go: downloading github.com/briandowns/openweathermap v0.0.0-20180804155945-5f41b7c9d92d
go: downloading github.com/zorkian/go-datadog-api v2.29.0+incompatible
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/rivo/uniseg v0.1.0
go: downloading golang.org/x/net v0.0.0-20200707034311-ab3426394381
go: downloading k8s.io/api v0.0.0-20181204000039-89a74a8d264d
go: downloading github.com/google/gofuzz v1.0.0
go: downloading golang.org/x/time v0.0.0-20191024005414-555d28b269f0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/lucasb-eyer/go-colorful v1.0.2
go: downloading github.com/microsoft/azure-devops-go-api/azuredevops v0.0.0-20191014190507-26902c1d4325
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/digitalocean/godo v1.42.1
go: downloading github.com/google/go-querystring v1.0.0
go: downloading google.golang.org/api v0.30.0
go: downloading github.com/wtfutil/spotigopher v0.0.0-20191127141047-7d8168fe103a
go: downloading code.cloudfoundry.org/bytefmt v0.0.0-20190819182555-854d396b647c
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/shirou/gopsutil v2.20.7+incompatible
go: downloading github.com/PagerDuty/go-pagerduty v0.0.0-20191002190746-f60f4fc45222
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/json-iterator/go v1.1.7
go: downloading github.com/godbus/dbus v4.1.0+incompatible
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/dlclark/regexp2 v1.2.0
go: downloading github.com/hekmon/transmissionrpc v0.0.0-20190525133028-1d589625bacd
go: downloading github.com/wtfutil/todoist v0.0.2-0.20191216004217-0ec29ceda61a
go: downloading github.com/stretchr/testify v1.6.1
go: downloading google.golang.org/appengine v1.6.6
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/google/uuid v1.1.1
go: downloading cloud.google.com/go v0.62.0
go: downloading github.com/adlio/trello v1.7.0
go: downloading github.com/zmb3/spotify v0.0.0-20191010212056-e12fb981aacb
go: downloading github.com/danwakefield/fnmatch v0.0.0-20160403171240-cbb64ac3d964
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/googleapis/gnostic v0.1.0
go: downloading gotest.tools v2.2.0+incompatible
go: downloading github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e
go: downloading github.com/mmcdole/gofeed v1.0.0
go: downloading github.com/gregjones/httpcache v0.0.0-20190212212710-3befbb6ad0cc
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/hekmon/cunits v2.0.1+incompatible
go: downloading github.com/docker/go-units v0.4.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading google.golang.org/protobuf v1.25.0
go: downloading github.com/mmcdole/goxpp v0.0.0-20181012175147-0068e33feabf
go: downloading github.com/jessevdk/go-flags v1.4.0
go: downloading github.com/google/go-cmp v0.5.1
go: downloading gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c
go: downloading github.com/Microsoft/go-winio v0.4.14
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/peterbourgon/diskv v2.0.1+incompatible
go: downloading github.com/StackExchange/wmi v0.0.0-20190523213315-cbe66965904d
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/gophercloud/gophercloud v0.5.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/nicklaw5/helix v0.5.9
go: downloading github.com/PuerkitoBio/goquery v1.5.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/andybalholm/cascadia v1.0.0
go: downloading github.com/google/btree v1.0.0
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/go-ole/go-ole v1.2.4
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading go.opencensus.io v0.22.4
go: downloading github.com/Azure/go-autorest v11.1.2+incompatible
go: downloading github.com/dgrijalva/jwt-go v3.2.0+incompatible
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading google.golang.org/genproto v0.0.0-20200804131852-c06518451d9c
go: downloading github.com/ovh/venom v0.25.0
go: downloading github.com/sguiheux/go-coverage v0.0.0-20190710153556-287b082a7197
go: downloading github.com/sirupsen/logrus v1.4.2
go: downloading github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b
go: downloading gopkg.in/AlecAivazis/survey.v1 v1.7.1
go: downloading github.com/fsamin/go-dump v1.0.9
go: downloading github.com/fatih/color v1.7.0
go: downloading github.com/spf13/cobra v0.0.5
go: downloading github.com/pborman/uuid v1.2.0
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/maruel/panicparse v1.3.0
go: downloading github.com/go-gorp/gorp v2.0.0+incompatible
go: downloading github.com/mitchellh/hashstructure v0.0.0-20170609045927-2bca23e0e452
go: downloading github.com/konsorten/go-windows-terminal-sequences v1.0.2
go: downloading github.com/eapache/go-resiliency v1.1.0
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/inconshreveable/mousetrap v1.0.0
go: downloading github.com/ovh/cds/sdk/interpolate v0.0.0-20190319104452-71125b036b25
go: downloading github.com/mitchellh/mapstructure v1.1.2
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/mndrix/tap-go v0.0.0-20170113192335-56cca451570b
go: downloading github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/aokoli/goutils v1.1.0
go: downloading github.com/huandu/xstrings v1.2.0
installing
hash mismatch in fixed-output derivation '/nix/store/cbn96y1r2h21a9zrsrr1ffgm25nlbcgg-wtf-0.32.0-go-modules':
  wanted: sha256:0l1q29mdb13ir7n1x65jfnrmy1lamlsa6hm2jagf6yjbm6wf1kw4
  got:    sha256:0p4cy7snxkx5in7c0nsy6bm0f1gn297rzwalm5rdfvhgdlb102nw
cannot build derivation '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv' failed
@aanderse
Copy link
Contributor

@aanderse aanderse commented Sep 28, 2020

@GrahamcOfBorg build wtf

@avdv
Copy link
Contributor Author

@avdv avdv commented Oct 6, 2020

wtf on x86_64-darwin Queued — Waiting to run this check... Started 7d 13h 20m 46s ago

I guess it got stuck and we can call this a failure?! What next?

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 6, 2020

f7e76d1 is failing to build for me on darwin x64. I propose we mark it as broken = stdenv.isDarwin

% nix-build -A wtf
these derivations will be built:
  /nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv
building '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv'...
unpacking sources
unpacking source archive /nix/store/7xd1c92n7i0pcpxb71qgfz7d0hasbcrf-source
source root is source
patching sources
configuring
building
Building subPackage ./.
modules/azuredevops/widget.go:7:2: cannot find package "." in:
        /private/var/folders/hk/77b9kbln51v8hgc1c6j767k00000gn/T/nix-build-wtf-0.32.0.drv-0/source/vendor/github.com/microsoft/azure-devops-go-api/azuredevops
modules/azuredevops/client.go:7:2: cannot find package "." in:
        /private/var/folders/hk/77b9kbln51v8hgc1c6j767k00000gn/T/nix-build-wtf-0.32.0.drv-0/source/vendor/github.com/microsoft/azure-devops-go-api/azuredevops/build
builder for '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv' failed with exit code 1
error: build of '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv' failed
@avdv avdv force-pushed the avdv:auto-update/wtf branch from f7e76d1 to aa67a1a Oct 7, 2020
@avdv
Copy link
Contributor Author

@avdv avdv commented Oct 7, 2020

I propose we mark it as broken = stdenv.isDarwin

Done.

I also removed the conditional vendor sha256 computation again and force pushed to the branch, original branch still available here.

pkgs/applications/misc/wtf/default.nix Outdated Show resolved Hide resolved
@stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 7, 2020

@avdv The commit message on b3fc088 doesn't match CONTRIBUTING.md#submitting-changes, either update the commit message to something like wtf: broken on darwin or add the change to the bump commit

* mark as broken on darwin

```
these derivations will be built:
/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv
building '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv'...
unpacking sources
unpacking source archive /nix/store/7xd1c92n7i0pcpxb71qgfz7d0hasbcrf-source
source root is source
patching sources
configuring
building
Building subPackage ./.
modules/azuredevops/widget.go:7:2: cannot find package "." in:
        /private/var/folders/hk/77b9kbln51v8hgc1c6j767k00000gn/T/nix-build-wtf-0.32.0.drv-0/source/vendor/github.com/microsoft/azure-devops-go-api/azuredevops
modules/azuredevops/client.go:7:2: cannot find package "." in:
          /private/var/folders/hk/77b9kbln51v8hgc1c6j767k00000gn/T/nix-build-wtf-0.32.0.drv-0/source/vendor/github.com/microsoft/azure-devops-go-api/azuredevops/build
builder for '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv' failed with exit code 1
error: build of '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv' failed
```
@avdv avdv force-pushed the avdv:auto-update/wtf branch from b3fc088 to fd04da1 Oct 7, 2020
@stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 7, 2020

@GrahamcOfBorg build wtf

@stigtsp
stigtsp approved these changes Oct 7, 2020
Copy link
Member

@stigtsp stigtsp left a comment

LGTM, thanks for fixing all the nitpicks :-)

Result of nixpkgs-review pr 98622 1

1 package built:
  • wtf
@stigtsp stigtsp merged commit 2c0dc38 into NixOS:master Oct 7, 2020
21 checks passed
21 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fd04da1"; rev="fd04da154062475a9e291c4ab2fac775393625f7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fd04da1"; rev="fd04da154062475a9e291c4ab2fac775393625f7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fd04da1"; rev="fd04da154062475a9e291c4ab2fac775393625f7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fd04da1"; rev="fd04da154062475a9e291c4ab2fac775393625f7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fd04da1"; rev="fd04da154062475a9e291c4ab2fac775393625f7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fd04da1"; rev="fd04da154062475a9e291c4ab2fac775393625f7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fd04da1"; rev="fd04da154062475a9e291c4ab2fac775393625f7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
wtf on aarch64-linux Success
Details
wtf on x86_64-linux Success
Details
wtf, wtf.passthru.tests on aarch64-linux Success
Details
wtf, wtf.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.