Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.{sseclient-py,python-nest}: init #98641

Merged
merged 3 commits into from Oct 4, 2020

Conversation

@JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Sep 24, 2020

Motivation for this change

Support nest in home assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@mweinelt mweinelt left a comment

I added some remarks, remember that you need to update the home-assistant component packages file through parse-requirement.py. That usually happens in a separate commit, since it touches the home-assistant package.

@mweinelt mweinelt self-assigned this Oct 2, 2020
@JamieMagee JamieMagee requested a review from mweinelt Oct 3, 2020
@JamieMagee
Copy link
Member Author

@JamieMagee JamieMagee commented Oct 3, 2020

Thanks for all the assistance. I'm still getting the hang of creating packages, and I had been reusing my work from previous python packages. I should be in a better position for future packages.

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 4, 2020

Result of nixpkgs-review pr 98641 1

6 packages built:
  • python27Packages.python-nest
  • python27Packages.sseclient-py
  • python37Packages.python-nest
  • python37Packages.sseclient-py
  • python38Packages.python-nest
  • python38Packages.sseclient-py

@mweinelt mweinelt merged commit 54c9db5 into NixOS:master Oct 4, 2020
18 checks passed
@JamieMagee JamieMagee deleted the python-nest branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants