Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.accuweather: init at 0.0.11 #98644

Merged
merged 2 commits into from Oct 18, 2020
Merged

Conversation

@JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Sep 24, 2020

Motivation for this change

support accuweather in home assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 2, 2020

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done without git rebase -i by doing:

git reset HEAD~1                    # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

However, git rebase -i is a more powerful alternative, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

@JamieMagee JamieMagee force-pushed the accuweather branch 2 times, most recently from 6841ecd to 5504d75 Oct 3, 2020
@JamieMagee JamieMagee requested a review from jonringer Oct 3, 2020
@JamieMagee
Copy link
Member Author

@JamieMagee JamieMagee commented Oct 3, 2020

Thanks! Still getting familiar with contributing to nixpkgs.

I've made the required changes and set the minimum python version at 3.8. The project doesn't list a specific Python version, only Python 3. However, the tests fail on anything less than Python 3.8, and given the module is only 3 months old, it's not a surprise.

@JamieMagee
Copy link
Member Author

@JamieMagee JamieMagee commented Oct 18, 2020

@jonringer Ready for review

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98644 1

1 package built:
  • python38Packages.accuweather

@jonringer jonringer merged commit e8b9945 into NixOS:master Oct 18, 2020
17 of 19 checks passed
@JamieMagee JamieMagee deleted the accuweather branch Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants