Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zombietrackergps: init at 1.01 #98689

Merged
merged 2 commits into from Oct 10, 2020
Merged

zombietrackergps: init at 1.01 #98689

merged 2 commits into from Oct 10, 2020

Conversation

@Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Sep 24, 2020

Motivation for this change

Closes #97065

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@0x4A6F
0x4A6F approved these changes Oct 7, 2020
Copy link
Contributor

@0x4A6F 0x4A6F left a comment

Reviewed points
  • package build on x86_64
  • executables tested on x86_64
2 packages built:
ldutils zombietrackergps
Comments

Stumbled upon problem described in eb6ac6a during testing, but otherwise it runs fine.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ldutils/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Sohalt
Copy link
Contributor Author

@Sohalt Sohalt commented Oct 9, 2020

@veprbl thanks for the review!

@Sohalt Sohalt force-pushed the Sohalt:zombie-tracker branch from df6beb6 to 7b1c3f2 Oct 9, 2020
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Sohalt Sohalt force-pushed the Sohalt:zombie-tracker branch from 7b1c3f2 to 0fd62d9 Oct 10, 2020
@Sohalt Sohalt force-pushed the Sohalt:zombie-tracker branch from 0fd62d9 to 4436869 Oct 10, 2020
@veprbl
veprbl approved these changes Oct 10, 2020
@veprbl veprbl merged commit e96fd6e into NixOS:master Oct 10, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4436869"; rev="4436869de3e613db65f55d2a467cb5ba1ecfc0c9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4436869"; rev="4436869de3e613db65f55d2a467cb5ba1ecfc0c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4436869"; rev="4436869de3e613db65f55d2a467cb5ba1ecfc0c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4436869"; rev="4436869de3e613db65f55d2a467cb5ba1ecfc0c9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4436869"; rev="4436869de3e613db65f55d2a467cb5ba1ecfc0c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4436869"; rev="4436869de3e613db65f55d2a467cb5ba1ecfc0c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4436869"; rev="4436869de3e613db65f55d2a467cb5ba1ecfc0c9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zombietrackergps, zombietrackergps.passthru.tests on aarch64-linux Success
Details
zombietrackergps, zombietrackergps.passthru.tests on x86_64-linux Success
Details

meta = with lib; {
description = "Headers and link library for other ldutils projects";
homepage = "https://gitlab.com/ldutils-projects/ldutils";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.