Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certbot: 1.7.0 -> 1.9.0 #98707

Merged
merged 1 commit into from Oct 12, 2020
Merged

certbot: 1.7.0 -> 1.9.0 #98707

merged 1 commit into from Oct 12, 2020

Conversation

@TredwellGit
Copy link
Member

@TredwellGit TredwellGit commented Sep 25, 2020

Motivation for this change

https://github.com/certbot/certbot/releases/tag/v1.8.0
https://github.com/certbot/certbot/releases/tag/v1.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
ajs124
ajs124 approved these changes Sep 28, 2020
Copy link
Member

@ajs124 ajs124 left a comment

@TredwellGit TredwellGit changed the title certbot: 1.7.0 -> 1.8.0 certbot: 1.7.0 -> 1.9.0 Oct 11, 2020
@TredwellGit TredwellGit requested a review from ajs124 Oct 11, 2020
@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 11, 2020

1.9 suggest calling certbot with --preconfigured-renewal, maybe the module should be changed to do that?

cc @domenkozar

@TredwellGit
Copy link
Member Author

@TredwellGit TredwellGit commented Oct 11, 2020

NixOS does not currently provide automated renewal, so that should not be done. I want to add an automated renewal module, but that can be done in another pull request.

ajs124
ajs124 approved these changes Oct 11, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98707 1

16 packages built:
  • certbot (python38Packages.certbot)
  • certbot-full
  • home-assistant
  • python27Packages.acme
  • python37Packages.acme
  • python37Packages.certbot
  • python37Packages.certbot-dns-cloudflare
  • python37Packages.certbot-dns-rfc2136
  • python37Packages.certbot-dns-route53
  • python37Packages.hass-nabucasa
  • python38Packages.acme
  • python38Packages.certbot-dns-cloudflare
  • python38Packages.certbot-dns-rfc2136
  • python38Packages.certbot-dns-route53
  • python38Packages.hass-nabucasa
  • simp_le

@jonringer jonringer merged commit cfed29b into NixOS:master Oct 12, 2020
19 checks passed
@TredwellGit TredwellGit deleted the certbot branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants