Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] linux-libre.scripts: 17537 -> 17624 #98768

Closed
wants to merge 1 commit into from

Conversation

@Uthar
Copy link
Contributor

@Uthar Uthar commented Sep 25, 2020

Motivation for this change

Fix #98764

Things done

updated rev of deblob scripts

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Uthar Uthar changed the title Update scripts argument to fix build (#98764) Update scripts argument to fix build Sep 25, 2020
@Uthar Uthar changed the title Update scripts argument to fix build linux-libre.scripts: 17537 -> 17624 Sep 25, 2020
@alyssais
Copy link
Member

@alyssais alyssais commented Oct 29, 2020

Hi! Thanks for the PR, and sorry I’m just getting around to it now towards the end of 20.03’s lifespan, but there’s still some time left for 20.03 so let’s try to get this in before the end.

PRs to release branches need to target release-* branches — the nixos-* branches are automatically updated once the release-* branches have been tested. You can change the target branch in the GitHub UI without having to make a new PR.

@Uthar Uthar changed the base branch from nixos-20.03 to release-20.03 Oct 29, 2020
@Uthar
Copy link
Contributor Author

@Uthar Uthar commented Oct 29, 2020

Hi :)
Sorry, I didn't know that the release branch should be targeted - changed that now.

This was some time ago, I wonder if the build is still passing, I'm going to check it in nix repl and write here soon. (Maybe a newer svn revision is needed)

@Uthar
Copy link
Contributor Author

@Uthar Uthar commented Oct 29, 2020

The build worked for me, so I think it can be merged.

@Uthar Uthar changed the title linux-libre.scripts: 17537 -> 17624 [20.03] linux-libre.scripts: 17537 -> 17624 Oct 31, 2020
@alyssais
Copy link
Member

@alyssais alyssais commented Nov 9, 2020

@GrahamcOfBorg build linuxPackages-libre

@alyssais
Copy link
Member

@alyssais alyssais commented Nov 9, 2020

@GrahamcOfBorg build linux-libre

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Due to the number of PRs nixpkgs gets every month we didn't review and merge this on in time before 20.03 hit EOL. If you think this PR is still relevant please rebase it on master or 20.09 and leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants