Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waybar: 0.9.3 -> 0.9.4 #98797

Merged
merged 1 commit into from Oct 2, 2020
Merged

waybar: 0.9.3 -> 0.9.4 #98797

merged 1 commit into from Oct 2, 2020

Conversation

@Jake-Gillberg
Copy link
Contributor

@Jake-Gillberg Jake-Gillberg commented Sep 25, 2020

Motivation for this change

Was frustrated with Alexays/Waybar#739

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 25, 2020

Copy link
Member

@minijackson minijackson left a comment

Result of nix-review pr 98797 1

1 package were built:
  • waybar

Tested with my config and sway 1.5 and it works fine 👍

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98797 1

1 package built:
  • waybar

@jonringer jonringer merged commit 6535c9f into NixOS:master Oct 2, 2020
19 checks passed
@sbruder sbruder mentioned this pull request Nov 2, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants