Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: fix segfaults on ppc64 #98822

Closed
wants to merge 1 commit into from
Closed

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Sep 26, 2020

Fixes NixOS/nix#2517

See also:
boostorg/context#72
boostorg/fiber#193

These issues have been resolved by:
boostorg/context#106
boostorg/context@d4608a4
which is merged into boost as of v1.71.0.

This feature was introduced (with the bug) in
boost v1.61 and was fixed in v1.71. So we apply
the patch to all versions in that range.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions - non-NixOS ppc64le, x86_64 (no change)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (should have NO IMPACT on non-ppc64 platforms)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@r-burns r-burns force-pushed the ppc64le-boost-segfault branch from 112443f to 562498c Sep 27, 2020
@r-burns r-burns changed the title nix: fix segfaults on ppc64 boost: fix segfaults on ppc64 Sep 27, 2020
@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Sep 27, 2020

I've updated this to what I believe is a more correct approach, since this is not actually an issue with nix. Since the bugfix in question applies cleanly to a large range of boost versions, I'm backporting the patch so that any other packages (not just nix) using older boost versions will also get the required fix. Again, this only applies to ppc64, so should not cause any rebuilds.

@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Sep 29, 2020

Pinging maintainer @peti, looks like ofborg didn't request review

@r-burns r-burns force-pushed the ppc64le-boost-segfault branch 2 times, most recently from e3a814f to a544fa2 Oct 15, 2020
@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Oct 15, 2020

Updated to use fetchpatch to cut down on patch bloat

@r-burns r-burns force-pushed the ppc64le-boost-segfault branch from a544fa2 to 3c093bc Oct 21, 2020
Fixes NixOS/nix#2517

See also:
boostorg/context#72
boostorg/fiber#193

These issues have been resolved by:
boostorg/context#106
boostorg/context@d4608a4
which is merged into boost as of v1.71.0.

This feature was introduced (with the bug) in
boost v1.61 and was fixed in v1.71. So we apply
the patch to all versions in that range.
@r-burns r-burns force-pushed the ppc64le-boost-segfault branch from 3c093bc to 969afc4 Oct 21, 2020
@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Oct 22, 2020

#100807 (comment)
Hmm this seems like a good guideline to follow. It will cause many rebuilds though, so I'm going to rebase and reissue this vs. staging.

@r-burns r-burns closed this Oct 22, 2020
@r-burns r-burns mentioned this pull request Oct 22, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant