Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.git-remote-codecommit: init at 1.15.1 #98847

Merged
merged 1 commit into from Sep 29, 2020

Conversation

@zaninime
Copy link
Contributor

@zaninime zaninime commented Sep 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zaninime zaninime force-pushed the git-remote-codecommit branch from 008bf7f to 95e3a3f Sep 29, 2020
@zaninime zaninime force-pushed the git-remote-codecommit branch from 95e3a3f to 66399b9 Sep 29, 2020
@zaninime zaninime changed the title python3Packages.git-remote-codecommit: init at 1.15.1 gitAndTools.git-remote-codecommit: init at 1.15.1 Sep 29, 2020
@zaninime
Copy link
Contributor Author

@zaninime zaninime commented Sep 29, 2020

@jonringer feel free to have a look again whenever you can.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98847 1

1 package built:
  • gitAndTools.git-remote-codecommit

@jonringer jonringer merged commit 6efc71f into NixOS:master Sep 29, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="66399b9"; rev="66399b9d42cc2842bc93689bfa92c822e96b6e70"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="66399b9"; rev="66399b9d42cc2842bc93689bfa92c822e96b6e70"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="66399b9"; rev="66399b9d42cc2842bc93689bfa92c822e96b6e70"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="66399b9"; rev="66399b9d42cc2842bc93689bfa92c822e96b6e70"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="66399b9"; rev="66399b9d42cc2842bc93689bfa92c822e96b6e70"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="66399b9"; rev="66399b9d42cc2842bc93689bfa92c822e96b6e70"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="66399b9"; rev="66399b9d42cc2842bc93689bfa92c822e96b6e70"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants