Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: 0.21.25 -> 0.22 #98869

Merged
merged 2 commits into from Oct 1, 2020
Merged

mpd: 0.21.25 -> 0.22 #98869

merged 2 commits into from Oct 1, 2020

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Sep 26, 2020

Motivation for this change

New version: https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v0.22/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closure size grows from 483.1 to 483.2 Mb.

@tobim tobim requested a review from doronbehar Sep 26, 2020
pkgs/servers/mpd/default.nix Show resolved Hide resolved
pkgs/servers/mpd/default.nix Outdated Show resolved Hide resolved
pkgs/servers/mpd/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested review from fpletz, astsmtl and ehmry Sep 26, 2020
doronbehar added a commit to tobim/nixpkgs that referenced this issue Sep 27, 2020
Experienced in:
NixOS#98869 (comment)

Set configure flags properly, don't override configurePhase, per:
https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md

Use different output names - use $bin for examples, and $out for
libraries which expectedly should be referenced by reverse desp.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 27, 2020

MPD now builds with liburing support, so I expect ofborg's MPD NixOS tests to pass.

@tobim
Copy link
Contributor Author

@tobim tobim commented Sep 30, 2020

@doronbehar I don't have anything to add here.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 1, 2020

@doronbehar I don't have anything to add here.

Oh sorry for keeping us waiting :) I was hoping to get your approval on my changes but I wasn't clear.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 1, 2020

Also @thoughtpolice doesn't express any objection, so I think this is good to go.

@@ -193,7 +197,7 @@ in
"yajl" "sqlite"
"soundcloud" "qobuz" "tidal"
] ++ lib.optionals stdenv.isLinux [
"alsa" "systemd" "syslog"
"alsa" "systemd" "syslog" /*"io_uring"*/
Copy link
Contributor

@doronbehar doronbehar Oct 1, 2020

Lucky I got thorough it once more, this needs to be uncommented.

doronbehar added a commit to tobim/nixpkgs that referenced this issue Oct 1, 2020
Experienced in:
NixOS#98869 (comment)

Set configure flags properly, don't override configurePhase, per:
https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md

Use different output names - use $bin for examples, and $out for
libraries which expectedly should be referenced by reverse desp.
Experienced in:
NixOS#98869 (comment)

Set configure flags properly, don't override configurePhase, per:
https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md

Use different output names - use $bin for examples, and $out for
libraries which expectedly should be referenced by reverse deps.
@doronbehar doronbehar merged commit 0a71571 into NixOS:master Oct 1, 2020
2 of 3 checks passed
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 1, 2020

This push fixed a typo in commit message.

dawidsowa added a commit to dawidsowa/nixpkgs that referenced this issue Oct 11, 2020
Experienced in:
NixOS#98869 (comment)

Set configure flags properly, don't override configurePhase, per:
https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md

Use different output names - use $bin for examples, and $out for
libraries which expectedly should be referenced by reverse deps.
@lopsided98 lopsided98 mentioned this pull request Oct 27, 2020
10 tasks
@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Oct 27, 2020

This broke cross compilation of liburing, see #101810 for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants