Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.blessed: 1.15.0 -> 1.17.10 #98886

Merged
merged 1 commit into from Oct 4, 2020

Conversation

@austinbutler
Copy link
Contributor

@austinbutler austinbutler commented Sep 26, 2020

Motivation for this change

Looking into fixing the inquirer Python package for ZHF and it depends on a new version of blessed. Also just to upgrade the package in general.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@austinbutler austinbutler force-pushed the austinbutler:blessed-upgrade branch from 603daee to 44cb5ca Sep 26, 2020
@austinbutler austinbutler requested a review from jonringer Sep 27, 2020
@austinbutler
Copy link
Contributor Author

@austinbutler austinbutler commented Oct 3, 2020

@jonringer I'm waiting on this PR for fixing https://hydra.nixos.org/build/128023281 and I think possibly it got lost in the shuffle.

@austinbutler austinbutler mentioned this pull request Oct 3, 2020
5 of 10 tasks complete
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 4, 2020

https://github.com/NixOS/nixpkgs/pull/98886
5 packages failed to build:
python37Packages.dask-xgboost python37Packages.myfitnesspal python37Packages.optuna python38Packages.dask-xgboost python38Packages.myfitnesspal

14 packages built:
awsebcli mailman-web python27Packages.blessed python37Packages.blessed python37Packages.datatable python37Packages.django-q python37Packages.hyperkitty python37Packages.mailman-web python37Packages.xgboost python38Packages.blessed python38Packages.datatable python38Packages.django-q python38Packages.hyperkitty python38Packages.xgboost

let me get #99575 in and retry

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/98886
3 packages failed to build:
python37Packages.myfitnesspal python37Packages.optuna python38Packages.myfitnesspal

16 packages built:
awsebcli mailman-web python27Packages.blessed python37Packages.blessed python37Packages.dask-xgboost python37Packages.datatable python37Packages.django-q python37Packages.hyperkitty python37Packages.mailman-web python37Packages.xgboost python38Packages.blessed python38Packages.dask-xgboost python38Packages.datatable python38Packages.django-q python38Packages.hyperkitty python38Packages.xgboost
@jonringer jonringer merged commit a231baa into NixOS:master Oct 4, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb5ca"; rev="44cb5ca1f6c12d014f1dd3ec07b1235ccef463ca"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb5ca"; rev="44cb5ca1f6c12d014f1dd3ec07b1235ccef463ca"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb5ca"; rev="44cb5ca1f6c12d014f1dd3ec07b1235ccef463ca"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb5ca"; rev="44cb5ca1f6c12d014f1dd3ec07b1235ccef463ca"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb5ca"; rev="44cb5ca1f6c12d014f1dd3ec07b1235ccef463ca"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb5ca"; rev="44cb5ca1f6c12d014f1dd3ec07b1235ccef463ca"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb5ca"; rev="44cb5ca1f6c12d014f1dd3ec07b1235ccef463ca"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@austinbutler austinbutler deleted the austinbutler:blessed-upgrade branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.