Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: remove scripts/go to fix go 1.15 build failure #98890

merged 1 commit into from Oct 5, 2020

grafana: remove scripts/go to fix go 1.15 build failure #98890

merged 1 commit into from Oct 5, 2020


Copy link

@zowoq zowoq commented Sep 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Using subPackages to avoid building this directory would be more
idiomatic but then we would lose the majority of the go tests.
@zowoq zowoq merged commit 5837509 into NixOS:master Oct 5, 2020
19 of 20 checks passed
@zowoq zowoq deleted the grafana branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant