Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material-shell: init at v6 #98899

Merged
merged 1 commit into from Sep 29, 2020
Merged

material-shell: init at v6 #98899

merged 1 commit into from Sep 29, 2020

Conversation

@benley
Copy link
Member

@benley benley commented Sep 27, 2020

New gnome-shell extension: https://material-shell.com/

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@benley
Copy link
Member Author

@benley benley commented Sep 29, 2020

I've been using this for the past several days with no issues, and this is a pretty straightforward PR so I'm just gonna merge it at this point

@benley benley merged commit 703f052 into NixOS:master Sep 29, 2020
17 checks passed
@benley benley deleted the material-shell branch Sep 29, 2020
@aaronjanse
Copy link
Member

@aaronjanse aaronjanse commented Sep 30, 2020

Thank you for packaging this @benley! I plan to start using this in the next couple weeks.

dawidsowa added a commit to dawidsowa/nixpkgs that referenced this issue Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants