Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdg-desktop-portal: 1.7.2 -> 1.8.0 #98909

Merged
merged 1 commit into from Sep 29, 2020

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Sep 27, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/flatpak/xdg-desktop-portal/releases.

meta.description for xdg-desktop-portal is: "Desktop integration portals for sandboxed apps"

meta.homepage for xdg-desktop-portal is: ""

meta.changelog for xdg-desktop-portal is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
xdg-desktop-portal
xdg-desktop-portal-gtk
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/n1njchfsjpjgvxfw0b2rn868vf8yd7s2-xdg-desktop-portal-1.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A xdg-desktop-portal https://github.com/r-ryantm/nixpkgs/archive/8b0aaac4d671dc7270e57467dee1d2c6afdd58ef.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/n1njchfsjpjgvxfw0b2rn868vf8yd7s2-xdg-desktop-portal-1.8.0
ls -la /nix/store/n1njchfsjpjgvxfw0b2rn868vf8yd7s2-xdg-desktop-portal-1.8.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages built:
  • xdg-desktop-portal
  • xdg-desktop-portal-gtk

Maintainer pings

cc @jtojnar for testing.

Copy link
Contributor

@jtojnar jtojnar left a comment

Installed tests are failing again but it is not a regression.

Changes look okay.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 27, 2020

Some of my test fixes were merged upstream but they do not seem to be sufficient. From the logs:

machine # ** (/nix/store/n1njchfsjpjgvxfw0b2rn868vf8yd7s2-xdg-desktop-portal-1.8.0/libexec/xdg-desktop-portal:728): WARNING **: 04:24:22.005: Failed connect to PipeWire: Couldn't connect to PipeWire
machine # ** (/nix/store/n1njchfsjpjgvxfw0b2rn868vf8yd7s2-xdg-desktop-portal-1.8.0/libexec/xdg-desktop-portal:728): WARNING **: 04:24:22.193: Failed to create wallpaper proxy: Error calling StartServiceByName for org.freedesktop.impl.portal.Test: The connection is closed
machine #
machine # [   19.769864] nscd[814]: 814 monitoring file `/etc/services` (6)
machine # ** (/nix/store/n1njchfsjpjgvxfw0b2rn868vf8yd7s2-xdg-desktop-portal-1.8.0/libexec/xdg-desktop-portal:728): WARNING **: 04:24:22.244: No skeleton to export
machine #
machine # [   19.793018] gnome-desktop-testing-runner
machine # (/nix/store/n1njchfsjpjgvxfw0b2rn868vf8yd7s2-xdg-desktop-portal-1.8.0/libexec/xdg-desktop-portal:728): GLib-GIO-CRITICAL **: 04:24:22.273: Error while sending AddMatch() message: The connection is closed
machine # [639]: FAIL: xdg-desktop-portal/test-portals.test (Child process killed by signal 5)
machine # (/nix/store/v3h6lv8khqg876q8rf3razcpkvf9vbbv-xdg-desktop-portal-1.8.0-installedTests/libexec/installed-tests/xdg-desktop-portal/test-portals:682): xdg-desktop-portal-ERROR **: 04:24:21.178: Failed to launch xdg-desktop-portal
machine # [   19.006317] traps: test-portals[682] trap int3 ip:7fc0a233e3f5 sp:7ffd615607e0 error:0 in libglib-2.0.so.0.6400.5[7fc0a2304000+81000]

@jtojnar jtojnar merged commit a7f375d into NixOS:master Sep 29, 2020
19 of 20 checks passed
@r-ryantm r-ryantm deleted the auto-update/xdg-desktop-portal branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants