Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klipper: init at 0.8.0 #98917

Merged
merged 2 commits into from Oct 12, 2020
Merged

klipper: init at 0.8.0 #98917

merged 2 commits into from Oct 12, 2020

Conversation

@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Sep 27, 2020

Motivation for this change

I need this to run the 3D printer I'm building. The firmware runs a daemon on a RPi that talks/commands it, which is what is being packaged here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
nixos/modules/services/misc/klipper.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/klipper.nix Outdated Show resolved Hide resolved
@lovesegfault lovesegfault force-pushed the klipper-init branch 2 times, most recently from efa7d8d to fb8ef7a Sep 27, 2020
Copy link
Member

@cole-h cole-h left a comment

Last nit I have is: I would separate this into two commits: klipper: init at 0.8.0, and nixos/klipper: init.

(Brownie points for using lib instead of stdenv.lib :) )

@lovesegfault
Copy link
Member Author

@lovesegfault lovesegfault commented Sep 28, 2020

Last nit I have is: I would separate this into two commits: klipper: init at 0.8.0, and nixos/klipper: init.

(Brownie points for using lib instead of stdenv.lib :) )

Done!

@lovesegfault lovesegfault requested a review from cole-h Sep 28, 2020
@lovesegfault lovesegfault force-pushed the klipper-init branch 2 times, most recently from 0b8751b to fc80004 Sep 29, 2020
cole-h
cole-h approved these changes Sep 29, 2020
Copy link
Member

@cole-h cole-h left a comment

Diff LGTM, thanks!

nixos/modules/services/misc/klipper.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/klipper.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/klipper.nix Outdated Show resolved Hide resolved
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
@lovesegfault lovesegfault requested a review from flokli Sep 29, 2020
@lovesegfault lovesegfault force-pushed the klipper-init branch 3 times, most recently from 8fb8fd8 to 24dce9e Oct 8, 2020
@lovesegfault
Copy link
Member Author

@lovesegfault lovesegfault commented Oct 8, 2020

Alright, I've tested this today and it works 🥳

Copy link
Member

@andir andir left a comment

Just some minor comments but looks good otherwise.

nixos/modules/services/misc/klipper.nix Show resolved Hide resolved
nixos/modules/services/misc/klipper.nix Outdated Show resolved Hide resolved
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
@lovesegfault lovesegfault requested a review from andir Oct 9, 2020
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
pkgs/servers/klipper/default.nix Show resolved Hide resolved
@lovesegfault lovesegfault requested a review from jtojnar Oct 9, 2020
@lovesegfault lovesegfault force-pushed the klipper-init branch 3 times, most recently from a2cb9df to dcef04d Oct 10, 2020
pkgs/servers/klipper/default.nix Outdated Show resolved Hide resolved
@lovesegfault lovesegfault requested a review from jtojnar Oct 11, 2020
@flokli flokli merged commit 399a2ab into NixOS:master Oct 12, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="97eadef"; rev="97eadef0c38c0b45d3cfa2287bc270000daed667"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="97eadef"; rev="97eadef0c38c0b45d3cfa2287bc270000daed667"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="97eadef"; rev="97eadef0c38c0b45d3cfa2287bc270000daed667"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="97eadef"; rev="97eadef0c38c0b45d3cfa2287bc270000daed667"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="97eadef"; rev="97eadef0c38c0b45d3cfa2287bc270000daed667"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="97eadef"; rev="97eadef0c38c0b45d3cfa2287bc270000daed667"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="97eadef"; rev="97eadef0c38c0b45d3cfa2287bc270000daed667"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
klipper, klipper.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
klipper, klipper.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants