Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.namedlist: 1.7 -> 1.8 #98967

Merged
merged 2 commits into from Sep 29, 2020
Merged

Conversation

@das-g
Copy link
Member

@das-g das-g commented Sep 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • (there are none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
das-g added 2 commits Sep 27, 2020
@das-g das-g requested review from FRidh and jonringer as code owners Sep 27, 2020
@das-g
Copy link
Member Author

@das-g das-g commented Sep 27, 2020

Result of nixpkgs-review pr 98967 1

1 package failed to build:
  • python37Packages.ludios_wpull
4 packages built:
  • grab-site
  • python27Packages.namedlist
  • python37Packages.namedlist
  • python38Packages.namedlist

@das-g das-g changed the title Python packages namedlist pythonPackages.namedlist: 1.7 -> 1.8 Sep 27, 2020
@ofborg ofborg bot requested a review from ivan Sep 27, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 98967 1

1 package marked as broken and skipped:
  • python37Packages.ludios_wpull
4 packages built:
  • grab-site
  • python27Packages.namedlist
  • python37Packages.namedlist
  • python38Packages.namedlist

@jonringer jonringer merged commit 638612d into NixOS:master Sep 29, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants