Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netsurf: a huge rewrite+update! #98991

Merged
merged 17 commits into from Sep 29, 2020
Merged

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 28, 2020

Motivation for this change

Refactor and update netsurf on nixpkgs.

Also, adding myself to maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@AndersonTorres
Copy link
Member Author

@AndersonTorres AndersonTorres commented Sep 29, 2020

@samueldr ping :)

@AndersonTorres AndersonTorres merged commit 9f97359 into NixOS:master Sep 29, 2020
17 checks passed
@AndersonTorres AndersonTorres deleted the netsurf-upload branch Sep 29, 2020
@dotlambda dotlambda mentioned this pull request Feb 1, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant