Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-review: 2.4.0 -> 2.4.1 #99024

Merged
merged 1 commit into from Sep 29, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 28, 2020

Motivation for this change

Fixes categorization of broken packages by using 'checkMeta' Mic92/nixpkgs-review#131

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/99024
1 package built:
nix-review
@jonringer jonringer requested a review from Mic92 Sep 28, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Sep 28, 2020

I still find it hilarious to use nixpkgs-review to review nixpkgs-review

@bhipple
Copy link
Contributor

@bhipple bhipple commented Sep 29, 2020

Result of nixpkgs-review pr 99024 1

1 package built:
- nixpkgs-review

@bhipple bhipple merged commit 7d25e51 into NixOS:master Sep 29, 2020
19 of 20 checks passed
@jonringer jonringer deleted the bump-nixpkgs-review branch Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants