Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minizinc: fix build against bison 3.7 #99034

Merged
merged 1 commit into from Sep 29, 2020
Merged

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Sep 28, 2020

Motivation for this change

ZHF: #97479

Wasn't compiling since we switched to bison 3.7. Problem fixed in upstream develop branch.

Also enable for darwin because it WFM macos 10.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
fixed in upstream development branch

enable for darwin
@risicle
Copy link
Contributor Author

@risicle risicle commented Sep 28, 2020

@ofborg build minizinc minizincide

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 29, 2020

I had a similar PR #98529 , however, I guess this just patches an official release, which is preferrable

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99034 1

2 packages built:
  • minizinc
  • minizincide

@jonringer jonringer merged commit 9f65c52 into NixOS:master Sep 29, 2020
21 checks passed
@risicle
Copy link
Contributor Author

@risicle risicle commented Sep 29, 2020

Hmm missed that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants