Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-rebuild: add impure #99038

Merged
merged 2 commits into from Sep 29, 2020
Merged

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 28, 2020

Motivation for this change

I need to be able to do --impure in nixos-rebuild.
I've built my system (flake) with this flag 馃槮

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace requested review from edolstra and cole-h Sep 28, 2020
cole-h
cole-h approved these changes Sep 28, 2020
Copy link
Member

@cole-h cole-h left a comment

Oops, I missed this list originally :D

Should the same be done for nixos-install? (Otherwise, you or people in the same situation as you might not be able to reinstall their system.)

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Sep 28, 2020

Should the same be done for nixos-install? (Otherwise, you or people in the same situation as you might not be able to reinstall their system.)

Totally, will push.

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Sep 28, 2020

Ah wait this probably need (for sure duplicated) documentation. I will push this, but I don't think I'll get to updating nixos-install just yet.

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Sep 28, 2020

Okay docs added.

@cole-h
Copy link
Member

@cole-h cole-h commented Sep 29, 2020

LGTM 馃憤

@worldofpeace worldofpeace merged commit 4065a45 into NixOS:master Sep 29, 2020
17 checks passed
@worldofpeace worldofpeace deleted the nixos-rebuild-impure branch Sep 29, 2020
ShamrockLee added a commit to ShamrockLee/nixpkgs that referenced this issue Feb 10, 2021
(cherry picked from commit 1343164)
Backport of NixOS#99038
ShamrockLee added a commit to ShamrockLee/nixpkgs that referenced this issue Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants