Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dnscrypt-proxy2: harden and improve service #99039

Merged
merged 1 commit into from Oct 2, 2020

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Sep 28, 2020

Motivation for this change

A lot of this is just culted from arch linux's service definition.
The one thing that's unique outside of this is the restartTriggers (I think they're needed?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Sep 30, 2020

It's also important that this just goes for network-online.target and not network.target https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

@worldofpeace worldofpeace force-pushed the worldofpeace:dnscrypt-proxy2-harden branch from a0736ee to 6e7e633 Oct 2, 2020
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Oct 2, 2020

@ofborg test dnscrypt-proxy2

@worldofpeace worldofpeace requested a review from aanderse Oct 2, 2020
Copy link
Contributor

@aanderse aanderse left a comment

LGTM 👍

@worldofpeace worldofpeace merged commit bd52e7f into NixOS:master Oct 2, 2020
18 checks passed
18 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e7e633"; rev="6e7e633a547a1ebfde51144963fd28c29d1b18b7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e7e633"; rev="6e7e633a547a1ebfde51144963fd28c29d1b18b7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e7e633"; rev="6e7e633a547a1ebfde51144963fd28c29d1b18b7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e7e633"; rev="6e7e633a547a1ebfde51144963fd28c29d1b18b7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e7e633"; rev="6e7e633a547a1ebfde51144963fd28c29d1b18b7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e7e633"; rev="6e7e633a547a1ebfde51144963fd28c29d1b18b7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e7e633"; rev="6e7e633a547a1ebfde51144963fd28c29d1b18b7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.dnscrypt-proxy2 on aarch64-linux Success
Details
tests.dnscrypt-proxy2 on x86_64-linux Success
Details
@worldofpeace worldofpeace deleted the worldofpeace:dnscrypt-proxy2-harden branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.