Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: enable ppc64le bootstrap #99056

Merged
merged 1 commit into from Nov 5, 2020
Merged

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Sep 29, 2020

Allows native bootstrapping from upstream binaries on ppc64le
Have been using ripgrep + bat compiled via the resulting bootstrapped rustc 1.45.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 19, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/341

@r-burns
Copy link
Contributor Author

@r-burns r-burns commented Oct 24, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 24, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@r-burns r-burns force-pushed the ppc64le-rust-bootstrap branch from 966c19b to 33eb9cd Nov 5, 2020
@r-burns r-burns requested a review from zowoq as a code owner Nov 5, 2020
Mic92
Mic92 approved these changes Nov 5, 2020
@Mic92 Mic92 merged commit bd01bae into NixOS:master Nov 5, 2020
18 checks passed
@r-burns r-burns deleted the ppc64le-rust-bootstrap branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants