Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlitecpp: init 3.1.1 #99063

Merged
merged 1 commit into from Apr 22, 2021
Merged

sqlitecpp: init 3.1.1 #99063

merged 1 commit into from Apr 22, 2021

Conversation

@jbedo
Copy link
Contributor

@jbedo jbedo commented Sep 29, 2020

Motivation for this change

Init GenomicSQLite and required SQLiteC++ dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@doronbehar doronbehar left a comment

It would have been nice if upstream was able to support building the zstd extension separately, and linking to it during runtime (if needed).

pkgs/development/libraries/genomicsqlite/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/genomicsqlite/default.nix Outdated Show resolved Hide resolved
@jbedo jbedo force-pushed the genomicsqlite branch 5 times, most recently from d06ffb5 to c98d704 Mar 29, 2021
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Mar 30, 2021

Note that there's also an eval error.

@jbedo jbedo force-pushed the genomicsqlite branch from c98d704 to f49c1ac Apr 19, 2021
@jbedo jbedo changed the title Genomicsqlite sqlitecpp: init 3.1.1 Apr 19, 2021
@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Apr 19, 2021

I've removed the genomicsqlite component of this as the expression contained a lot of hacky workarounds and upstream wasn't responsive making me think maintenance will be an issue in future.

Copy link
Contributor

@doronbehar doronbehar left a comment

LGTM overall.

pkgs/development/libraries/sqlitecpp/default.nix Outdated Show resolved Hide resolved
@jbedo jbedo force-pushed the genomicsqlite branch from f49c1ac to c1290da Apr 21, 2021
@ofborg ofborg bot requested a review from doronbehar Apr 21, 2021
@doronbehar doronbehar merged commit 5bad492 into NixOS:master Apr 22, 2021
21 checks passed
21 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
labels
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
ofborg-eval ^.^!
Details
@ofborg[bot]
ofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
ofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
ofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1290da"; rev="c1290daeaa29770559839b9287a7a896c3db11d5"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
ofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1290da"; rev="c1290daeaa29770559839b9287a7a896c3db11d5"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1290da"; rev="c1290daeaa29770559839b9287a7a896c3db11d5"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1290da"; rev="c1290daeaa29770559839b9287a7a896c3db11d5"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1290da"; rev="c1290daeaa29770559839b9287a7a896c3db11d5"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1290da"; rev="c1290daeaa29770559839b9287a7a896c3db11d5"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1290da"; rev="c1290daeaa29770559839b9287a7a896c3db11d5"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
ofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
ofborg-eval-started Evaluation started
Details
@ofborg[bot]
sqlitecpp, sqlitecpp.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
sqlitecpp, sqlitecpp.passthru.tests on x86_64-linux Success
Details
{ lib, stdenv, fetchFromGitHub, cmake, sqlite, cppcheck, gtest }:

stdenv.mkDerivation rec {
pname = "SQLiteCpp";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Apr 22, 2021

pname should match the attribute name.

Copy link
Contributor

@doronbehar doronbehar Apr 22, 2021

@SuperSandro2000 thanks for the review. I noticed you comment this a lot. Is it a convention agreed upon in an RFC somewhere?

Copy link
Member

@SuperSandro2000 SuperSandro2000 Apr 24, 2021

It isn't since some wrappers and other things add something additional to the attr name but thats not the case here and it is only confusing when the package shows up as something else in the searches or env.

];

meta = with lib; {
homepage = "http://srombauts.github.com/SQLiteCpp";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Apr 22, 2021

That homepage is wrong. The correct is https://srombauts.github.io/SQLiteCpp/

Copy link
Contributor

@doronbehar doronbehar Apr 22, 2021

Good catch!

@jbedo jbedo mentioned this pull request Apr 27, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants