Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptraf: mark as broken #99087

Merged
merged 1 commit into from Sep 29, 2020
Merged

iptraf: mark as broken #99087

merged 1 commit into from Sep 29, 2020

Conversation

@elohmeier
Copy link
Contributor

@elohmeier elohmeier commented Sep 29, 2020

Motivation for this change

Required headers have been removed from the linux kernel, the original project is pretty much unmaintained, see also iptraf-ng as an potential alternative.

Build fails, see https://hydra.nixos.org/build/127639950

Should be backported to 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@elohmeier
Copy link
Contributor Author

@elohmeier elohmeier commented Sep 29, 2020

Backported in #99089

@elohmeier elohmeier force-pushed the elohmeier:iptraf branch from 713c4d8 to 376ee6d Sep 29, 2020
@elohmeier
Copy link
Contributor Author

@elohmeier elohmeier commented Sep 29, 2020

Fixed typo.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99087 1

@jonringer jonringer merged commit 5b65d3e into NixOS:master Sep 29, 2020
18 checks passed
18 checks passed
@github-actions
tests tests
Details
@github-actions
action
Details
@ofborg
iptraf, iptraf.passthru.tests on aarch64-linux No attempt
Details
@ofborg
iptraf, iptraf.passthru.tests on x86_64-linux No attempt
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="376ee6d"; rev="376ee6dbcdbc26e3b6aa64fd18f18566969d5b1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="376ee6d"; rev="376ee6dbcdbc26e3b6aa64fd18f18566969d5b1d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="376ee6d"; rev="376ee6dbcdbc26e3b6aa64fd18f18566969d5b1d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="376ee6d"; rev="376ee6dbcdbc26e3b6aa64fd18f18566969d5b1d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="376ee6d"; rev="376ee6dbcdbc26e3b6aa64fd18f18566969d5b1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="376ee6d"; rev="376ee6dbcdbc26e3b6aa64fd18f18566969d5b1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="376ee6d"; rev="376ee6dbcdbc26e3b6aa64fd18f18566969d5b1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants