Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] iptraf: mark as broken #99089

Merged
merged 1 commit into from Sep 29, 2020
Merged

Conversation

@elohmeier
Copy link
Contributor

@elohmeier elohmeier commented Sep 29, 2020

(cherry picked from commit 713c4d8)

#97479

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@elohmeier elohmeier mentioned this pull request Sep 29, 2020
10 tasks
@elohmeier
Copy link
Contributor Author

@elohmeier elohmeier commented Sep 29, 2020

Fixed typo.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 29, 2020

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

(cherry picked from commit 5b65d3e)
@elohmeier
Copy link
Contributor Author

@elohmeier elohmeier commented Sep 29, 2020

Thanks @jonringer, my mind was a bit in a hurry ;-) Fixed it.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99089 1

@jonringer jonringer merged commit b562e7d into NixOS:release-20.09 Sep 29, 2020
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants