Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: move chktex from texlive.bin.core to texlive.bin.chktex #99093

Merged
merged 1 commit into from Oct 6, 2020

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Sep 29, 2020

chktex binary doesn't work without its global resource file which
comes in its tlType="run" package. This commit moves chktex into a
separate tlType="bin" package so it is only used along with its
tlType="run" counterpart.

Motivation for this change

Fixes: #10377

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
# nix path-info -Sh `readlink before`
/nix/store/p7ylazwg2zn5g58s5ldp2z8y0kcwjs1h-texlive-combined-small-2019  430.1M
# nix path-info -Sh `readlink after` 
/nix/store/z5vq5mb8zlj05f7nbyqbd1q9irl146mf-texlive-combined-small-2019  430.0M
chktex binary doesn't work without its global resource file which
comes in its tlType="run" package. This commit moves chktex into a
separate tlType="bin" package so it is only used along with its
tlType="run" counterpart.
@veprbl veprbl merged commit 86e6adc into NixOS:master Oct 6, 2020
17 checks passed
@veprbl veprbl deleted the pr/texlive_chktex_fix branch Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant