Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gegl_0_4: make vapi dependencies explicit #99112

Merged
merged 1 commit into from Sep 29, 2020
Merged

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 29, 2020

Motivation for this change

Hopefully address #99108

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Sep 29, 2020

@ofborg build gimp

@vcunat
Copy link
Member

@vcunat vcunat commented Sep 29, 2020

The bot won't help, I believe. There's been no darwin builder in there for weeks and the queue has skyrocketed: https://monitoring.nix.ci/d/000000002/ofborg?refresh=10s&orgId=1&from=now-30d&to=now&fullscreen&panelId=9 It's sad, as I'm not aware of how you can get e.g. a darwin VM for free (contrary to all other platforms here).

So... /cc @NixOS/darwin-maintainers?

@LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 29, 2020

@vcunat Yeah, my builder died.

I do have a relatively nice way to build or setup an interactive session with github. Here's a build https://github.com/LnL7/nix-darwin/runs/1184455133?check_suite_focus=true.

LnL7
LnL7 approved these changes Sep 29, 2020
Copy link
Member

@LnL7 LnL7 left a comment

Still building gimp, but this already fixes gegl itself.

Copy link
Contributor

@jtojnar jtojnar left a comment

I do not understand how does this issue occur on MacOS but not on Linux but if the patch fixes GEGL build 👍 – we also need this patch to build #67576, even on Linux.

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Sep 29, 2020

I do not understand how does this issue occur on MacOS but not on Linux but if the patch fixes GEGL build +1 – we also need this patch to build #67576, even on Linux.

Yeah, that part to me is also highly mysterious.

@worldofpeace worldofpeace merged commit effaddc into NixOS:master Sep 29, 2020
20 of 23 checks passed
@worldofpeace worldofpeace deleted the gegl-fix branch Sep 29, 2020
@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Sep 29, 2020

LnL confirmed on irc that gimp now builds 👍

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Sep 29, 2020

backported to 20.09 in 663ff87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants