Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noto-fonts-emoji: Work around Hydra silence timeouts on AArch64 by being noisy #99119

Merged
merged 1 commit into from Sep 30, 2020

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Sep 29, 2020

Motivation for this change

This package is timing out with the current situation of AArch64 builds on the organization's Hydra.

building of '/nix/store/m2ks0z3wgixmwq0xrjl9nmxinv1l15qn-noto-fonts-emoji-unstable-2020-08-20' timed out after 7200 seconds of silence

It seems to always be out of being silent. I have not observed a failure due to exhausting all its build time yet. My assumption is that file I/O is problematic on the somewhat overloaded AArch64 builders, and churning silently through thousands of files is breaking an assumption from Hydra: "silent builds are failing".

cc @worldofpeace @jonringer for a backport.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(Currently building on my machine, I believe it'll end up building just fine.) Took fifteen minutes to build, was noisy.

The added noise should keep Hydra from stopping this build thinking it
is hanging doing nothing, while in fact it's just churning slowly
through thousands of funny pictures!
@samueldr samueldr changed the title noto-fonts-emoji: Work around Hydra silence timeouts by being noisy noto-fonts-emoji: Work around Hydra silence timeouts on AArch64 by being noisy Sep 29, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

although kind of a hack, but what can you do :)

@samueldr
Copy link
Member Author

@samueldr samueldr commented Sep 29, 2020

A better solution would be to upstream a patch that adds some verbosity if desired.

Though yes, totally a workaround, could stop working at any point, but if it stops working I think it'll become a no-op.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

I'm fine with this. This would probably make some desktops (tests?) build on aarch64 again

@samueldr
Copy link
Member Author

@samueldr samueldr commented Sep 29, 2020

I don't know how much of AArch64 is held back by this, but I assume some is. My main selfish reason is Mobile NixOS is being held back here.

@samueldr samueldr merged commit 4c3b84c into NixOS:master Sep 30, 2020
19 of 20 checks passed
@samueldr samueldr deleted the fix/noto-emoji-hangs branch Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants