Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: 0.44.0 -> 0.45.0 #99138

Merged
merged 1 commit into from Oct 2, 2020
Merged

starship: 0.44.0 -> 0.45.0 #99138

merged 1 commit into from Oct 2, 2020

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 30, 2020

Motivation for this change

https://github.com/starship/starship/releases/tag/v0.45.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam
Copy link
Contributor Author

@marsam marsam commented Sep 30, 2020

@GrahamcOfBorg build starship

@bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 30, 2020

You have this problem?

  failures:
      modules::directory::tests::directory_in_home
      modules::directory::tests::fish_directory_in_home
      modules::directory::tests::truncated_directory_in_home

  test result: FAILED. 447 passed; 3 failed; 26 ignored; 0 measured; 0 filtered out

I spent hours yesterday trying to figure it out. (well while doing other things between rebuilds)

@bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 30, 2020

also please update to v0.45.1

@berbiche
Copy link
Contributor

@berbiche berbiche commented Sep 30, 2020

You have this problem?

  failures:
      modules::directory::tests::directory_in_home
      modules::directory::tests::fish_directory_in_home
      modules::directory::tests::truncated_directory_in_home

  test result: FAILED. 447 passed; 3 failed; 26 ignored; 0 measured; 0 filtered out

I spent hours yesterday trying to figure it out. (well while doing other things between rebuilds)

Judging from the tests titles, writing to $HOME should result in a failure inside the build because of the sandbox.

@bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 30, 2020

Judging from the tests titles, writing to $HOME should result in a failure inside the build because of the sandbox.

Yeah I know. Sorry I wasn't clear. The tests are supposed to be disabled, and they are not. That's the problem I had yesterday.

@marsam marsam force-pushed the marsam:update-starship branch from c6c3662 to 1e87a3d Oct 1, 2020
@marsam
Copy link
Contributor Author

@marsam marsam commented Oct 1, 2020

The tests are supposed to be disabled, and they are not.

indeed, it's failing because checkFlagsArray gets quoted and treated as a single argument:

cargo test -j $NIX_BUILD_CORES ${argstr} -- --test-threads=${threads} ''${checkFlags} ''${checkFlagsArray+"''${checkFlagsArray[@]}"}

I'm going to submit a PR to fix buildRustPackage later

@marsam marsam marked this pull request as ready for review Oct 1, 2020
@marsam marsam force-pushed the marsam:update-starship branch from 1e87a3d to 9e78f73 Oct 2, 2020
@marsam marsam merged commit 16a679f into NixOS:master Oct 2, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
starship, starship.passthru.tests on x86_64-darwin
Details
starship, starship.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e78f73"; rev="9e78f73ba5642fa1a5683ad7c9c6e88cb790fe60"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e78f73"; rev="9e78f73ba5642fa1a5683ad7c9c6e88cb790fe60"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e78f73"; rev="9e78f73ba5642fa1a5683ad7c9c6e88cb790fe60"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e78f73"; rev="9e78f73ba5642fa1a5683ad7c9c6e88cb790fe60"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e78f73"; rev="9e78f73ba5642fa1a5683ad7c9c6e88cb790fe60"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e78f73"; rev="9e78f73ba5642fa1a5683ad7c9c6e88cb790fe60"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e78f73"; rev="9e78f73ba5642fa1a5683ad7c9c6e88cb790fe60"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
starship, starship.passthru.tests on x86_64-linux Success
Details
@marsam marsam deleted the marsam:update-starship branch Oct 2, 2020
@bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 2, 2020

thanks @marsam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.