Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.protobuf: fix cross-compilation #99141

Merged
merged 1 commit into from Oct 25, 2020

Conversation

@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Sep 30, 2020

Motivation for this change

Fixes cross-compilation of the protobuf Python library. This may need #98915 to actually successfully cross-compile (I haven't tested it without it), but I don't think that needs to block merging this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Ericson2314 @jonringer @dotlambda @delroth

@lopsided98 lopsided98 requested review from FRidh and jonringer as code owners Sep 30, 2020
@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Sep 30, 2020

This may fail:

@ofborg build pkgsCross.armv7l-hf-multiplatform.python3Packages.protobuf

@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Sep 30, 2020

@ofborg build pkgsCross.aarch64-multiplatform.python3Packages.protobuf

FRidh
FRidh approved these changes Sep 30, 2020
@FRidh FRidh merged commit 50277eb into NixOS:master Oct 25, 2020
21 checks passed
@lopsided98 lopsided98 deleted the protobuf-cross branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants