Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/moodle: add missing PHP module #99163

Merged
merged 1 commit into from Oct 3, 2020

Conversation

@jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Sep 30, 2020

Motivation for this change

Without the filter extension the service moodle-init-start fails.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse
Copy link
Member

@aanderse aanderse commented Sep 30, 2020

ping @Kloenk

@Kloenk
Copy link
Member

@Kloenk Kloenk commented Sep 30, 2020

On my system it works and succeds with the current nixpkgs master. Do you have any special config for which this is needed?

@jmpunkt
Copy link
Contributor Author

@jmpunkt jmpunkt commented Sep 30, 2020

My local master is on a7f375d. Found this issue while scrolling through the ZHF for 20.09. The Hydra build for 20.09 fails on all architectures. It was possible for me to reproduce the same error also on the master branch. Adding the filter extensions solves the problem, which makes sense based on the error message.

@Kloenk
Copy link
Member

@Kloenk Kloenk commented Oct 3, 2020

This is also missing for h5p, so looks ready to merge to me

@petabyteboy petabyteboy merged commit 07988a0 into NixOS:master Oct 3, 2020
16 checks passed
16 checks passed
@github-actions
tests tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e8fb41"; rev="9e8fb415ff41c8aae6134a282f2f9dacff428a1f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e8fb41"; rev="9e8fb415ff41c8aae6134a282f2f9dacff428a1f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e8fb41"; rev="9e8fb415ff41c8aae6134a282f2f9dacff428a1f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e8fb41"; rev="9e8fb415ff41c8aae6134a282f2f9dacff428a1f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e8fb41"; rev="9e8fb415ff41c8aae6134a282f2f9dacff428a1f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e8fb41"; rev="9e8fb415ff41c8aae6134a282f2f9dacff428a1f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9e8fb41"; rev="9e8fb415ff41c8aae6134a282f2f9dacff428a1f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 3, 2020

Make sure to file a backport and mark it as ZHF!

@jmpunkt jmpunkt mentioned this pull request Oct 3, 2020
2 of 10 tasks
@jmpunkt jmpunkt deleted the jmpunkt:moodle--missing-extension branch Oct 3, 2020
petabyteboy pushed a commit that referenced this pull request Oct 3, 2020
siraben added a commit to siraben/nixpkgs that referenced this pull request Oct 5, 2020
dawidsowa added a commit to dawidsowa/nixpkgs that referenced this pull request Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants