Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.TextDiffFormattedHTML: init at 0.08 #99169

Merged

Conversation

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 30, 2020

Motivation for this change

This PR adds the Text::Diff::FormattedHTML Perl module, and dependencies.

dependencies:

perlPackages.ModuleInstallGithubMeta: init at 0.30
perlPackages.ModuleInstallReadmeFromPod: init at 0.30
perlPackages.ModuleInstallReadmeMarkdownFromPod: init at 0.04
perlPackages.ModuleInstallRepository: init at 0.06
perlPackages.StringDiff: init at 0.07
perlPackages.TestInDistDir: init at 1.112071

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@stigtsp stigtsp requested review from volth and aanderse Sep 30, 2020
@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Sep 30, 2020

@GrahamcOfBorg build perlPackages.TextDiffFormattedHTML
@GrahamcOfBorg build perldevelPackages.TextDiffFormattedHTML

Copy link
Member

@aanderse aanderse left a comment

Quick glance LGTM 👍

@stigtsp stigtsp merged commit 874cf05 into NixOS:master Oct 1, 2020
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants