Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidermonkey: remove spidermonkey_38 -> spidermonkey alias #99172

Merged
merged 2 commits into from Oct 1, 2020

Conversation

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Sep 30, 2020

This removes the spidermonkey alias and renames it in the packages still
using it

Not sure if we need it in aliases.nix since just about nothing depends
on it anymore

Additionally considering removal should be a good choice, it's at least
insecure so it should get tagged as such

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mkg20001 mkg20001 force-pushed the spidermonkey-38 branch from 87c395f to 3b234b4 Sep 30, 2020
Copy link
Contributor

@jtojnar jtojnar left a comment

In my understanding, the aliases are there primarily for end-users, eg. if someone needs a JavaScript interpreter. There are more complete choices available (gjs or nodejs) so I doubt anybody uses it but the cost of keeping an alias in aliases.nix is low so we tend to create them these days.

@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Sep 30, 2020

Unsure if I should set it to a higher version. Spidermonkey 38 is vulnerable and shouldn't be used anymore, tho more recent versions aren't ABI compatible so should I rather remove it?

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 30, 2020

Setting it to latest version would be nice too.

@mkg20001 mkg20001 force-pushed the spidermonkey-38 branch 2 times, most recently from 6e5ce98 to a4d073c Oct 1, 2020
mkg20001 added 2 commits Oct 1, 2020
This removes the spidermonkey alias and renames it in the packages still
using it

Not sure if we need it in aliases.nix since just about nothing depends
on it anymore

Additionally considering removal should be a good choice, it's at least
insecure so it should get tagged as such
@mkg20001 mkg20001 force-pushed the spidermonkey-38 branch from a4d073c to 5ad4389 Oct 1, 2020
@mkg20001 mkg20001 merged commit b3f8d3b into NixOS:master Oct 1, 2020
18 checks passed
@mkg20001 mkg20001 deleted the spidermonkey-38 branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants