Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.graspy: rename to python3Packages.graspologic #99183

merged 1 commit into from Oct 25, 2020


Copy link

@bcdarwin bcdarwin commented Sep 30, 2020

neurodata/graspy has merged with microsoft/topologic and now redirects to microsoft/graspologic.

There hasn't been a new release since the merger, so this is only a metadata change (note the source hash is the same).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners Sep 30, 2020
@bcdarwin bcdarwin force-pushed the graspy-to-graspologic branch from 13696fa to d1d7524 Sep 30, 2020
@bcdarwin bcdarwin force-pushed the graspy-to-graspologic branch from d1d7524 to 06d66d5 Sep 30, 2020
@bcdarwin bcdarwin changed the title graspy: rename to graspologic python3Packages.graspy: rename to python3Packages.graspologic Sep 30, 2020
Copy link

@jonringer jonringer commented Sep 30, 2020

@FRidh do you care about having an alias pointing from the old to the new? I don't really mind. Branch-off has already occurred

@FRidh FRidh merged commit 8e17389 into NixOS:master Oct 25, 2020
17 checks passed
Copy link

@FRidh FRidh commented Oct 25, 2020

I typically prefer not to have aliases, which is a bit against the general rule I think.

@bcdarwin bcdarwin deleted the graspy-to-graspologic branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants