Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giara init #99188

Closed
wants to merge 1 commit into from
Closed

Giara init #99188

wants to merge 1 commit into from

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Sep 30, 2020

Motivation for this change

https://www.reddit.com/r/linux/comments/j2hqmi/giara_is_a_reddit_app_and_its_finally_sorta/

Depends on #98316 for libhandy update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 30, 2020

libhandy update is backwards incompatible, see #98316

@bqv
Copy link
Contributor

@bqv bqv commented Oct 7, 2020

@Atemu I see on your issue that you got this working, could you bump the rev?

@Atemu Atemu changed the base branch from master to gnome-3.38 Oct 16, 2020
@Atemu Atemu marked this pull request as ready for review Oct 16, 2020
@Atemu
Copy link
Member Author

@Atemu Atemu commented Oct 16, 2020

Giara has a tagged release now.

@Atemu
Copy link
Member Author

@Atemu Atemu commented Oct 16, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 16, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 16, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@bqv
Copy link
Contributor

@bqv bqv commented Oct 16, 2020

Needs bumping before review, as it stands from my test it doesn't work

Forgive me, I keep forgetting this app doesn't show commit updates

@bqv
Copy link
Contributor

@bqv bqv commented Oct 16, 2020

Thanks..?

@Atemu
Copy link
Member Author

@Atemu Atemu commented Oct 17, 2020

Huh odd, what made Marvin think @bqv agreed to do a review? @timokau

I'm pretty sure they are going to do that but it's not been said explicitly.

I think such a response is surprising as a potential reviewer who doesn't have time right now could just set the awaiting_reviewer manually.

bqv
bqv approved these changes Oct 17, 2020
Copy link
Contributor

@bqv bqv left a comment

Works good and well!

@bqv
Copy link
Contributor

@bqv bqv commented Oct 17, 2020

@GrahamcOfBorg eval

Edit: unsure why borg hates this

pkgs/applications/networking/giara/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/giara/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/giara/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/giara/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/giara/default.nix Outdated Show resolved Hide resolved
@timokau
Copy link
Member

@timokau timokau commented Oct 18, 2020

Huh odd, what made Marvin think @bqv agreed to do a review? @timokau

Basically any comment from somebody that is not the PR-author is treated as a potential "review". Its a heuristic of course, with the intent to keep the "needs reviewer" queue as uncluttered as possible. If its inaccurate, you can always set it back or wait until it times out. But I think its usually accurate.

I think such a response is surprising as a potential reviewer who doesn't have time right now could just set the awaiting_reviewer manually.

I think relying on that would mean much more manual status changes, which probably just won't happen. Then the "needs reviewer" queue has a bunch of PRs that actually are already in review, which can be demotivating when going through the queue manually and which can waste reviewer capacity when marvin assigns reviewers.

The name of the label maybe isn't ideal. "awaiting_reviwer" means that the PR is currently in review, and marvin is not sure weather or not the reviewer has actually requested any changes. The only difference to "awaiting_changes" is that marvin will eventually time out "awaiting_reviwer" back to "needs_reviewer".

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 21, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@bqv
Copy link
Contributor

@bqv bqv commented Oct 21, 2020

/status needs_changes

@timokau
Copy link
Member

@timokau timokau commented Oct 21, 2020

/status awaiting_changes

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 31, 2020

Any warnings in the terminal about the images?

@Atemu
Copy link
Member Author

@Atemu Atemu commented Oct 31, 2020

Nope :/

@bqv
Copy link
Contributor

@bqv bqv commented Oct 31, 2020

I would hazard a guess that cairo might be missing in some form

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 31, 2020

This seems to work for me:

{ lib
, fetchFromGitLab
, meson
, gobject-introspection
, pkg-config
, ninja
, python3
, wrapGAppsHook
, gtk3
, gdk-pixbuf
, webkitgtk
, gtksourceview4
, libhandy
, glib-networking
}:

python3.pkgs.buildPythonApplication rec {
  pname = "giara";
  version = "0.2";

  format = "other";

  src = fetchFromGitLab {
    domain = "gitlab.gnome.org";
    owner = "World";
    repo = pname;
    rev = version;
    sha256 = "1ca7ldf0rd19aixbdjvamqs55f3iig9wahgczik24r6knxj1bxl4";
  };

  nativeBuildInputs = [
    meson
    gobject-introspection
    pkg-config
    ninja
    wrapGAppsHook
  ];

  buildInputs = [
    gtk3
    gdk-pixbuf
    webkitgtk
    gtksourceview4
    libhandy
    glib-networking
  ];

  pythonPath = with python3.pkgs; [
    pygobject3
    pycairo
    dateutil
    praw
    pillow
    mistune
    beautifulsoup4
  ];

  # Fix setup-hooks https://github.com/NixOS/nixpkgs/issues/56943
  strictDeps = false;

  meta = with lib; {
    description = "A Reddit app, built with Python, GTK and Handy. Created with mobile Linux in mind.";
    maintainers = with maintainers; [ atemu ];
    homepage = "https://gitlab.gnome.org/World/giara";
    license = licenses.gpl3Plus;
    platforms = platforms.linux;
  };
}

Had to sniff the Location header reddit redirected to, since Firefox does not like the custom protocol: https://web.archive.org/web/20200613135416/https://www.fxsitecompat.dev/en-CA/docs/2020/navigation-to-unknown-protocol-will-be-blocked/, and then run giara 'URL' to be able to log in, thought.

@srid
Copy link
Contributor

@srid srid commented Oct 31, 2020

@jtojnar That installed giara, but it fails to launch:

Traceback (most recent call last):
  File "/nix/store/q9rx4800vvyl7rxls8sdnl9fvw809456-giara-0.2/bin/..giara-wrapped-wrapped", line 70, in <module>
    gi.require_version('Handy', '1')
  File "/nix/store/hi5fmb38iy9ykp33g4gqh1h1kc520q8j-python3.8-pygobject-3.36.1/lib/python3.8/site-packages/gi/__init__.py", line 132, in require_version
    raise ValueError('Namespace %s not available for ver

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 31, 2020

@srid If you are rebasing onto unstable, you need to include the libhandy bump (in staging).

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 3, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@bqv
Copy link
Contributor

@bqv bqv commented Nov 3, 2020

@jtojnar would you perhaps just push your changes so this can be merged, since that works?

@bqv
Copy link
Contributor

@bqv bqv commented Nov 6, 2020

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 6, 2020

Cannot do that at the moment, but feel free to open a new PR against staging-next.

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 9, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

1 similar comment
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 12, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

Copy link
Member

@timokau timokau left a comment

The repeated notifications are a bug (timokau/marvin-mk2#99). Seems like this is blocked by the libhandy thing if I understand it correctly.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 12, 2020

@timokau libhandy is in master now so it needs a rebase and changing the expression to #99188 (comment) to fix the bugs reported above.

@Atemu
Copy link
Member Author

@Atemu Atemu commented Dec 10, 2020

I don't intend on packaging this anymore, feel free to pick this up.

@Atemu Atemu closed this Dec 10, 2020
@dasj19 dasj19 mentioned this pull request Jan 27, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants