Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.debugpy: 1.0.0b12 -> 1.0.0 #99213

Merged
merged 1 commit into from Oct 1, 2020
Merged

Conversation

@kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Oct 1, 2020

Motivation for this change

Upgrade to the first official release: https://github.com/microsoft/debugpy/releases/tag/v1.0.0

Also fixes the Python 2.7 build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

    $ nix-env -f /home/kira/.cache/nixpkgs-review/rev-7539c63103c14fe3ed5da473fa26988d71b51450/nixpkgs -qaP --xml --out-path --show-trace --meta
    1 package added:
    python27Packages.debugpy (init at 1.0.0)
    
    2 packages updated:
    python37Packages.debugpy (1.0.0b12 → 1.0.0) python38Packages.debugpy (1.0.0b12 → 1.0.0)
    
    $ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/kira/.cache/nixpkgs-review/rev-7539c63103c14fe3ed5da473fa26988d71b51450/build.nix
    3 packages built:
    python27Packages.debugpy python37Packages.debugpy python38Packages.debugpy
    
  • Tested execution of all binary files (usually in ./result/bin/)
    No bin files, only a python library. Tested through dap-mode in Emacs.

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

Copy link
Member

@mweinelt mweinelt left a comment

I added some recommendations on how to improve the package.

pkgs/development/python-modules/debugpy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/debugpy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/debugpy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/debugpy/default.nix Outdated Show resolved Hide resolved
Also fixes the Python 2.7 build
@kira-bruneau
Copy link
Contributor Author

@kira-bruneau kira-bruneau commented Oct 1, 2020

@mweinelt Do these changes look good to you now?

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

LGTM.

Result of nixpkgs-review pr 99213 1

3 packages built:
  • python27Packages.debugpy
  • python37Packages.debugpy
  • python38Packages.debugpy

@mweinelt mweinelt merged commit 6cf69de into NixOS:master Oct 1, 2020
17 checks passed
@kira-bruneau kira-bruneau deleted the debugpy branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants