Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: Remove references from emacs.pdmp #99239

Merged
merged 1 commit into from Oct 1, 2020
Merged

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Oct 1, 2020

Motivation for this change

This reduces the Emacs closure size from 1324 MiB to 424 MiB.

Fixes #98755.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This reduces the Emacs closure size from 1324 MiB to 424 MiB.

Fixes NixOS#98755.
@edolstra edolstra requested a review from adisbladis as a code owner Oct 1, 2020
@edolstra
Copy link
Member Author

@edolstra edolstra commented Oct 1, 2020

Note that Emacs is still about 85 MiB larger than in NixOS 20.03. For a large part this is because the closure now contains two (!) copies of systemd, where previously it only depended on systemd.lib.

Edit: I created issue #99240 for that. We could just drop the systemd dependency in Emacs (looking at the source, it only affects running Emacs in daemon mode as a systemd unit, which I doubt anybody really cares about). However that wouldn't help since Emacs also depends on dbus, which in turn depends on systemd.

@ofborg ofborg bot added the 6.topic: emacs label Oct 1, 2020
@ofborg ofborg bot requested review from peti and jwiegley Oct 1, 2020
@adisbladis adisbladis merged commit ff9d09b into NixOS:master Oct 1, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
emacs, emacs.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
emacs, emacs.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
emacs, emacs.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e13d34"; rev="8e13d34944cfc70d17e246d1cbe878611fa93451"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e13d34"; rev="8e13d34944cfc70d17e246d1cbe878611fa93451"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e13d34"; rev="8e13d34944cfc70d17e246d1cbe878611fa93451"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e13d34"; rev="8e13d34944cfc70d17e246d1cbe878611fa93451"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e13d34"; rev="8e13d34944cfc70d17e246d1cbe878611fa93451"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e13d34"; rev="8e13d34944cfc70d17e246d1cbe878611fa93451"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e13d34"; rev="8e13d34944cfc70d17e246d1cbe878611fa93451"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 1, 2020

it only affects running Emacs in daemon mode as a systemd unit

And to add to this, it's only relevant for socket activation, which the NixOS service doesn't use.
But as you say, emacs depends on dbus anyway so it's probably not worth the extra effort, and it would be pretty nice to switch the emacs service over to use socket activation.

@edolstra edolstra deleted the emacs-closure branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants