Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnadd: init at 1.0.0 #99248

Merged
merged 2 commits into from Nov 28, 2020
Merged

Conversation

@JoeLancaster
Copy link
Member

@JoeLancaster JoeLancaster commented Oct 1, 2020

Motivation for this change

I wanted a tool to add NixOS packages with a single command (nix-env -i style) that still works declaratively and leaves my system congruent to my configuration.nix

Other users may also find it helpful

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@fzakaria
Copy link
Contributor

@fzakaria fzakaria commented Oct 1, 2020

Result of nixpkgs-review pr 99248 1

1 package built:
- nixadd

Copy link
Contributor

@jonringer jonringer left a comment

seems that this uses nixos-rebuild as the entry point, which is only available on nixos. Should it be called nixosadd?

pkgs/tools/nix/nixadd/default.nix Outdated Show resolved Hide resolved
@fzakaria
Copy link
Contributor

@fzakaria fzakaria commented Oct 1, 2020

As a review of a package & Nix expression it looks 👍 ; as a tool I have somewhat the same feedback as @jonringer

I just worry about namespacing now in nixpkgs too with the number of pkgs present & how easy it's become for everyone to submit their own tool.

@JoeLancaster JoeLancaster force-pushed the joelancaster-nixadd-v1_0_0 branch 3 times, most recently from 14e3b6c to e1de9b5 Oct 2, 2020
@JoeLancaster JoeLancaster changed the title nixadd: init at 1.0.0 dnadd: init at 1.0.0 Oct 2, 2020
@JoeLancaster
Copy link
Member Author

@JoeLancaster JoeLancaster commented Oct 3, 2020

@fzakaria @jonringer You both make good points and I agree that community projects' superfluous use of nix probably steps on the toes of the official tooling. I've renamed the project to dnadd.

pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
@JoeLancaster JoeLancaster force-pushed the joelancaster-nixadd-v1_0_0 branch from e1de9b5 to 1c54d3d Oct 5, 2020
@JoeLancaster JoeLancaster force-pushed the joelancaster-nixadd-v1_0_0 branch from 1c54d3d to 3a5b3ef Oct 5, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 28, 2020

Result of nixpkgs-review pr 99248 run on x86_64-linux 1

1 package built:
  • dnadd

@SuperSandro2000 SuperSandro2000 merged commit 9445441 into NixOS:master Nov 28, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
dnadd, dnadd.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
dnadd, dnadd.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3a5b3ef"; rev="3a5b3ef85e8ef3cf7ecfa3ae7b1823d068e04933"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3a5b3ef"; rev="3a5b3ef85e8ef3cf7ecfa3ae7b1823d068e04933"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3a5b3ef"; rev="3a5b3ef85e8ef3cf7ecfa3ae7b1823d068e04933"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3a5b3ef"; rev="3a5b3ef85e8ef3cf7ecfa3ae7b1823d068e04933"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3a5b3ef"; rev="3a5b3ef85e8ef3cf7ecfa3ae7b1823d068e04933"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3a5b3ef"; rev="3a5b3ef85e8ef3cf7ecfa3ae7b1823d068e04933"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3a5b3ef"; rev="3a5b3ef85e8ef3cf7ecfa3ae7b1823d068e04933"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants