Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/httpd: remove unnecessary sendmail configuration #99251

Merged

Conversation

@xfix
Copy link
Contributor

@xfix xfix commented Oct 1, 2020

PHP now uses system-sendmail without special configuration (see #95898).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
PHP now uses system-sendmail without special configuration.
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 1, 2020

Looks like

sendmail_path = "/run/wrappers/bin/sendmail -t -i"
can be cleaned up a bit too. @xfix - are you interested in tackling that?

@xfix xfix requested a review from aanderse Oct 2, 2020
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 3, 2020

ping @NixOS/php

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 3, 2020

@GrahamcOfBorg test php.fpm php.httpd

@etu
etu approved these changes Oct 3, 2020
@aanderse aanderse merged commit dedd676 into NixOS:master Oct 5, 2020
18 checks passed
18 checks passed
@github-actions
tests tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6fc06a1"; rev="6fc06a1d3d789eea00cadc17373ebae992e53867"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6fc06a1"; rev="6fc06a1d3d789eea00cadc17373ebae992e53867"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6fc06a1"; rev="6fc06a1d3d789eea00cadc17373ebae992e53867"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6fc06a1"; rev="6fc06a1d3d789eea00cadc17373ebae992e53867"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6fc06a1"; rev="6fc06a1d3d789eea00cadc17373ebae992e53867"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6fc06a1"; rev="6fc06a1d3d789eea00cadc17373ebae992e53867"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6fc06a1"; rev="6fc06a1d3d789eea00cadc17373ebae992e53867"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
tests.php.fpm, tests.php.httpd on aarch64-linux Success
Details
@ofborg
tests.php.fpm, tests.php.httpd on x86_64-linux Success
Details
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 5, 2020

Thanks @xfix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants