Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TabNine cli and completion-tabnine vim plugin #99264

Merged
merged 5 commits into from Oct 1, 2020
Merged

Conversation

@onsails
Copy link
Contributor

@onsails onsails commented Oct 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@onsails onsails force-pushed the tabnine branch 2 times, most recently from b7b7461 to a82354e Oct 1, 2020
@onsails onsails requested a review from jonringer as a code owner Oct 1, 2020
@onsails onsails changed the title tabnine: init at 3.1.1 Add TabNine cli and comletion-tabnine vim plugin Oct 1, 2020
@onsails onsails changed the title Add TabNine cli and comletion-tabnine vim plugin Add TabNine cli and completion-tabnine vim plugin Oct 1, 2020
@onsails onsails force-pushed the tabnine branch 2 times, most recently from 3dedee9 to 4f43303 Oct 1, 2020
Copy link
Contributor

@jonringer jonringer left a comment

missing update commit

When adding new vim plugins, please follow directions for adding new vim plugins.

The steps should roughly be:

git checkout -b <branch-name>
GITHUB_API_TOKEN=[personal token] ./pkgs/misc/vim-plugins/update.py --add "[owner]/[name]"
git push <fork> <branch>

you should see the following in your commit history:

vimPlugins: update
vimPlugins.[name]: init at <date>

If the package needs additional patching or you want to include a meta section, please put the related changes in pkgs/misc/vim-plugins/overrides.nix. Do not edit the generated.nix, as those changes will be lost next update.

Why GITHUB_API_TOKEN?
Github limits github queries to 100/hr if you're a guest, but if you have a personal token, it will raise it to 5000/hr. The vim plugin update script will query the repositories to see what the latest release was, which will exceed the unauthenticated query limit.

For documentation on creating a token, please refer to the official docs

pkgs/development/tools/tabnine/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

do you mind updating vim-clap's cargoSha, looks like they updated the lockfile

https://github.com/NixOS/nixpkgs/pull/99264
2 packages marked as broken and skipped:
tabnine vimPlugins.completion-tabnine

1 package failed to build:
vimPlugins.vim-clap

41 packages built:
vimPlugins.Coqtail vimPlugins.Supertab vimPlugins.Syntastic vimPlugins.Tagbar vimPlugins.YouCompleteMe vimPlugins.ale vimPlugins.coc-explorer vimPlugins.coc-markdownlint vimPlugins.completion-nvim vimPlugins.diagnostic-nvim vimPlugins.direnv-vim vimPlugins.easymotion vimPlugins.fugitive vimPlugins.lh-brackets vimPlugins.lh-vim-lib vimPlugins.neoformat vimPlugins.neoterm vimPlugins.nvim-gdb vimPlugins.nvim-treesitter vimPlugins.polyglot vimPlugins.tmuxNavigator vimPlugins.vim-abolish vimPlugins.vim-autoformat vimPlugins.vim-cue vimPlugins.vim-elixir vimPlugins.vim-go vimPlugins.vim-gutentags vimPlugins.vim-javascript-syntax vimPlugins.vim-jsx-pretty vimPlugins.vim-lsc vimPlugins.vim-lsp vimPlugins.vim-monokai vimPlugins.vim-rails vimPlugins.vim-snippets vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-which-key vimPlugins.vimspector vimPlugins.vimtex vimPlugins.vista-vim vimPlugins.yats-vim

@onsails
Copy link
Contributor Author

@onsails onsails commented Oct 1, 2020

do you mind updating vim-clap's cargoSha, looks like they updated the lockfile

https://github.com/NixOS/nixpkgs/pull/99264
2 packages marked as broken and skipped:
tabnine vimPlugins.completion-tabnine

1 package failed to build:
vimPlugins.vim-clap

41 packages built:
vimPlugins.Coqtail vimPlugins.Supertab vimPlugins.Syntastic vimPlugins.Tagbar vimPlugins.YouCompleteMe vimPlugins.ale vimPlugins.coc-explorer vimPlugins.coc-markdownlint vimPlugins.completion-nvim vimPlugins.diagnostic-nvim vimPlugins.direnv-vim vimPlugins.easymotion vimPlugins.fugitive vimPlugins.lh-brackets vimPlugins.lh-vim-lib vimPlugins.neoformat vimPlugins.neoterm vimPlugins.nvim-gdb vimPlugins.nvim-treesitter vimPlugins.polyglot vimPlugins.tmuxNavigator vimPlugins.vim-abolish vimPlugins.vim-autoformat vimPlugins.vim-cue vimPlugins.vim-elixir vimPlugins.vim-go vimPlugins.vim-gutentags vimPlugins.vim-javascript-syntax vimPlugins.vim-jsx-pretty vimPlugins.vim-lsc vimPlugins.vim-lsp vimPlugins.vim-monokai vimPlugins.vim-rails vimPlugins.vim-snippets vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-which-key vimPlugins.vimspector vimPlugins.vimtex vimPlugins.vista-vim vimPlugins.yats-vim

sure, will do it in a few minutes.
Where can I see this report? I don't see anything like this in github actions...

@onsails onsails requested a review from jonringer Oct 1, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 1, 2020

I'm running nixpkgs-review

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 99264"

it's also one of the bullets on the template

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99264 1

2 packages marked as broken and skipped:
  • tabnine
  • vimPlugins.completion-tabnine
1 package failed to build:
  • vimPlugins.vim-clap
41 packages built:
  • vimPlugins.Coqtail
  • vimPlugins.Supertab (vimPlugins.supertab)
  • vimPlugins.Syntastic (vimPlugins.syntastic)
  • vimPlugins.Tagbar (vimPlugins.tagbar)
  • vimPlugins.YouCompleteMe
  • vimPlugins.ale
  • vimPlugins.coc-explorer
  • vimPlugins.coc-markdownlint
  • vimPlugins.completion-nvim
  • vimPlugins.diagnostic-nvim
  • vimPlugins.direnv-vim
  • vimPlugins.easymotion (vimPlugins.vim-easymotion)
  • vimPlugins.fugitive (vimPlugins.vim-fugitive)
  • vimPlugins.lh-brackets
  • vimPlugins.lh-vim-lib
  • vimPlugins.neoformat
  • vimPlugins.neoterm
  • vimPlugins.nvim-gdb
  • vimPlugins.nvim-treesitter
  • vimPlugins.polyglot (vimPlugins.vim-polyglot)
  • vimPlugins.tmuxNavigator (vimPlugins.tmux-navigator ,vimPlugins.vim-tmux-navigator)
  • vimPlugins.vim-abolish
  • vimPlugins.vim-autoformat
  • vimPlugins.vim-cue
  • vimPlugins.vim-elixir
  • vimPlugins.vim-go
  • vimPlugins.vim-gutentags
  • vimPlugins.vim-javascript-syntax
  • vimPlugins.vim-jsx-pretty
  • vimPlugins.vim-lsc
  • vimPlugins.vim-lsp
  • vimPlugins.vim-monokai
  • vimPlugins.vim-rails
  • vimPlugins.vim-snippets
  • vimPlugins.vim-test
  • vimPlugins.vim-visual-multi
  • vimPlugins.vim-which-key
  • vimPlugins.vimspector
  • vimPlugins.vimtex
  • vimPlugins.vista-vim
  • vimPlugins.yats-vim

@jonringer jonringer merged commit f89fcf4 into NixOS:master Oct 1, 2020
2 of 3 checks passed
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 1, 2020

I should have built the unfree packages:

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-99264-2]$ nix-build ./nixpkgs/ -A tabnine
these derivations will be built:
  /nix/store/jghiqgm6a1hwdws81w9dwxqdrplz84wd-TabNine.drv
  /nix/store/8va6xq5rflfvkn8vcw8vnwrb783gygnh-tabnine-3.1.1.drv
building '/nix/store/jghiqgm6a1hwdws81w9dwxqdrplz84wd-TabNine.drv'...

trying https://update.tabnine.com/3.1.1/x86_64-unknown-linux-musl/TabNine
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15.1M  100 15.1M    0     0  7414k      0  0:00:02  0:00:02 --:--:-- 7414k
hash mismatch in fixed-output derivation '/nix/store/0l29blcimkb75b87r1xqlri6sqba198p-TabNine':
  wanted: sha256:0p366iz1sdby289ldblq7rag90s08j47m0p2n4kg82a8ib5izrf3
  got:    sha256:13iram89cxym8s3q2sa925gprwsb3y70q3fxp92i9n1kcijnsac5

@onsails
Copy link
Contributor Author

@onsails onsails commented Oct 1, 2020

I'll make a new PR to fix this

@onsails onsails deleted the tabnine branch Oct 1, 2020
@jonringer jonringer mentioned this pull request Oct 1, 2020
10 tasks
@onsails onsails mentioned this pull request Oct 1, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants